Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ability to edit devworkspaces #421

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Fix the ability to edit devworkspaces #421

merged 2 commits into from
Dec 10, 2021

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Dec 10, 2021

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Fix the ability to edit DevWorkspaces in the dashboard.

What issues does this PR fix or reference?

fixes eclipse-che/che#20737
fixes eclipse-che/che#20889

Is it tested? How?

  1. Create a new devworkspace.
  2. Do some changes (e.g. change an image in the conteiner) in the devfile editor and pres 'save' button.
2021-12-10.17.33.37.mov

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #421 (7f2d3f6) into main (f304883) will increase coverage by 0.03%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   49.57%   49.60%   +0.03%     
==========================================
  Files         210      211       +1     
  Lines        7240     7243       +3     
  Branches     1198     1199       +1     
==========================================
+ Hits         3589     3593       +4     
+ Misses       3311     3309       -2     
- Partials      340      341       +1     
Impacted Files Coverage Δ
...ontend/src/store/Workspaces/devWorkspaces/index.ts 10.89% <0.00%> (+0.15%) ⬆️
...oard-frontend/src/store/DevfileRegistries/index.ts 25.00% <20.00%> (+0.55%) ⬆️
...end/src/pages/WorkspaceDetails/EditorTab/index.tsx 57.01% <50.00%> (-0.75%) ⬇️
...nd/src/store/DevfileRegistries/getDevfileSchema.ts 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f304883...7f2d3f6. Read the comment docs.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-421

@che-bot
Copy link
Contributor

che-bot commented Dec 10, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Dec 10, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Dec 10, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 10, 2021

New changes are detected. LGTM label has been removed.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-421

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-421

@che-bot
Copy link
Contributor

che-bot commented Dec 10, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@olexii4 olexii4 merged commit d1462c8 into main Dec 10, 2021
@olexii4 olexii4 deleted the CHE-20737 branch December 10, 2021 16:50
@che-bot che-bot added this to the 7.41 milestone Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to edit DevWorkspace in dashboard [UD] The ability to update a running devworkspace is broken.
3 participants