-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the ability to edit devworkspaces #421
Conversation
Codecov Report
@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 49.57% 49.60% +0.03%
==========================================
Files 210 211 +1
Lines 7240 7243 +3
Branches 1198 1199 +1
==========================================
+ Hits 3589 3593 +4
+ Misses 3311 3309 -2
- Partials 340 341 +1
Continue to review full report at Codecov.
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-421 |
✅ E2E dashboard tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Signed-off-by: Oleksii Orel <oorel@redhat.com>
packages/dashboard-frontend/src/store/__tests__/DevfileRegistries/getDevfileSchema.spec.ts
Outdated
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-421 |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-421 |
✅ E2E dashboard tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Signed-off-by: Oleksii Orel oorel@redhat.com
What does this PR do?
Fix the ability to edit DevWorkspaces in the dashboard.
What issues does this PR fix or reference?
fixes eclipse-che/che#20737
fixes eclipse-che/che#20889
Is it tested? How?
2021-12-10.17.33.37.mov