Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request devfile JSON schema #424

Merged
merged 1 commit into from
Dec 13, 2021
Merged

fix: request devfile JSON schema #424

merged 1 commit into from
Dec 13, 2021

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR fixes the issue that the dashboard is not able ot fetch a devfile schema.

What issues does this PR fix or reference?

fixes eclipse-che/che#20919

Is it tested? How?

Use the dashboard image from this PR

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #424 (78b1507) into main (d1462c8) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   49.60%   49.61%           
=======================================
  Files         211      211           
  Lines        7243     7242    -1     
  Branches     1199     1199           
=======================================
  Hits         3593     3593           
+ Misses       3309     3308    -1     
  Partials      341      341           
Impacted Files Coverage Δ
...oard-frontend/src/store/DevfileRegistries/index.ts 25.27% <25.00%> (+0.27%) ⬆️
...e/DevfileRegistries/fetchAndUpdateDevfileSchema.ts 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1462c8...78b1507. Read the comment docs.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-424

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the image and I don't reproduce the error

Also I'm able to start DevWorkspaces

@openshift-ci
Copy link

openshift-ci bot commented Dec 13, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, benoitf, ibuziuk

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@che-bot
Copy link
Contributor

che-bot commented Dec 13, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@akurinnoy akurinnoy merged commit 6dcde16 into main Dec 13, 2021
@akurinnoy akurinnoy deleted the CHE-20919 branch December 13, 2021 14:47
@che-bot che-bot added this to the 7.41 milestone Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to request devfile JSON schema, reason: Cannot read properties of undefined (reading 'remoteAPI')
4 participants