Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to show a warning banner by configuring CheCluster CR #466

Merged
merged 3 commits into from
Feb 24, 2022

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

The Dashboard looks into the CheCluster CR for a warning message:

spec:
  dashboard:
    warning: "Eclipse Che hosted by Red Hat is going to ..."

and shows it as a permanent banner.

Screenshots Screenshot 2022-02-23 at 14 03 02 Screenshot 2022-02-23 at 14 03 24

What issues does this PR fix or reference?

eclipse-che/che#20724

@akurinnoy akurinnoy self-assigned this Feb 23, 2022
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-466

@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2022

@akurinnoy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-dashboard-happy-path 0b7dd95 link true /test v8-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants