Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply registry and dashboard URL on all components #481

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Mar 18, 2022

What does this PR do?

Apply env variables not only in the template components but also in the devWorkspace components

What issues does this PR fix or reference?

Fixes eclipse-che/che#21102

Is it tested? How?

Check CHE_* env variables are defined in the user container

Release Notes

Docs PR

@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2022

Click here to review and test in web IDE: Contribute

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #481 (50be7e0) into main (69b6bca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   53.60%   53.61%           
=======================================
  Files         230      230           
  Lines        8010     8011    +1     
  Branches     1348     1349    +1     
=======================================
+ Hits         4294     4295    +1     
  Misses       3322     3322           
  Partials      394      394           
Flag Coverage Δ
unittests 53.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...orkspace-client/devworkspace/devWorkspaceClient.ts 47.72% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b6bca...50be7e0. Read the comment docs.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-481

@benoitf benoitf marked this pull request as ready for review March 18, 2022 10:50
@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, amisevsk, benoitf, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benoitf benoitf merged commit 638510c into main Mar 21, 2022
@benoitf benoitf deleted the CHE-21102 branch March 21, 2022 09:42
@che-bot che-bot added this to the 7.46 milestone Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no CHE_DASHBOARD_URL or PLUGIN_REGISTRY_URL in the dev container
6 participants