Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding a container registry flow #610

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Fix adding a container registry flow #610

merged 1 commit into from
Aug 29, 2022

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Aug 26, 2022

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Fix adding a container registry from Dashboard/User Preferences.

What issues does this PR fix or reference?

fixes eclipse-che/che#21589

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 requested a review from ibuziuk August 26, 2022 23:46
@olexii4 olexii4 requested a review from akurinnoy as a code owner August 26, 2022 23:46
@che-bot
Copy link
Contributor

che-bot commented Aug 26, 2022

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 changed the title Fix container registry flow Fix adding a container registry flow Aug 26, 2022
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-610

@openshift-ci
Copy link

openshift-ci bot commented Aug 27, 2022

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-dashboard-happy-path 0ea48b2 link true /test v8-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 24c9652 into main Aug 29, 2022
@olexii4 olexii4 deleted the CHE_21589 branch August 29, 2022 10:56
@che-bot che-bot added this to the 7.53 milestone Aug 29, 2022
olexii4 added a commit that referenced this pull request Aug 31, 2022
Signed-off-by: Oleksii Orel <oorel@redhat.com>
olexii4 added a commit that referenced this pull request Sep 1, 2022
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a container registry from Dashboard User preferences doesn't work
4 participants