chore: Document the usage of the che-server API #723
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-723 |
1 similar comment
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-723 |
Codecov Report
@@ Coverage Diff @@
## main #723 +/- ##
=======================================
Coverage 63.42% 63.42%
=======================================
Files 288 288
Lines 8602 8602
Branches 1357 1357
=======================================
Hits 5456 5456
Misses 2922 2922
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
@akurinnoy @olexii4 folks, could you please review and confirm that those are the only API used by the dashboard
README.md
Outdated
| | GET | /workspace/settings | | ||
| | GET | /oauth | | ||
| | GET | /oauth/authenticate | | ||
| | GET | /oauth/callback | |
There was a problem hiding this comment.
BTW: che-workspace-client doesn't support bouth /oauth/callback and /oauth/authenticate.
I think we should remove them.
@akurinnoy WDYT?
There was a problem hiding this comment.
I saw both /oauth/callback and /oauth/authenticate in network tab. Where do they come from?
There was a problem hiding this comment.
@tolusha We probably need them for the authorization flow.
There was a problem hiding this comment.
@olexii4 those requests are not initiated by the dashboard
There was a problem hiding this comment.
@olexii4 @akurinnoy folks, but who is doing /oauth/callback && /oauth/authenticate ?
|
Click here to review and test in web IDE: |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-723 |
|
Build 3.6 :: dashboard_3.x/189: Console, Changes, Git Data |
|
Build 3.6 :: sync-to-downstream_3.x/2296: Console, Changes, Git Data |
|
Build 3.6 :: get-sources-rhpkg-container-build_3.x/2175: dashboard : 3.x :: |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Document the usage of the che-server API
What issues does this PR fix or reference?
eclipse-che/che#21848
Is it tested? How?
N/A
Release Notes
N/A
Docs PR
N/A