Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create multiarch image manifest with tools compatible with lates… #734

Closed
wants to merge 1 commit into from

Conversation

mkuznyetsov
Copy link
Contributor

…t buildx extension

What does this PR do?

'docker manifest create' won't work with images build from latest buildx extension, because of provenance attestations.
the solution is to replace this command with 'build imagetools" util that can work with images built in such way

What issues does this PR fix or reference?

eclipse-che/che#21954

Is it tested? How?

tested on forked repo action

Release Notes

Docs PR

@openshift-ci
Copy link

openshift-ci bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkuznyetsov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@che-bot
Copy link
Contributor

che-bot commented Feb 22, 2023

Click here to review and test in web IDE: Contribute

…t buildx extension

Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Feb 22, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-734

@nickboldt
Copy link
Contributor

discussed and rejected as not necessary

@nickboldt nickboldt closed this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants