Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve local-run flow #839

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Improve local-run flow #839

merged 1 commit into from
Jun 19, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jun 15, 2023

What does this PR do?

Improve local-run flow(CHE in CHE developing).

What issues does this PR fix or reference?

It needs for eclipse-che/che#22237

Is it tested? How?

  1. Create a new workspace from https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/#https://github.com/eclipse-che/che-dashboard/tree/locul_run
  2. Run the following commands: install dependencies, build, dogfooding prepare, start che-in-che.
    Знімок екрана 2023-06-16 о 13 17 03
  3. Copy the endpoint for the local-server and open it in a new tab.
    Знімок екрана 2023-06-16 о 13 14 42
  4. The local-run session should be started.
    Знімок екрана 2023-06-16 о 13 15 14

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Jun 15, 2023

Click here to review and test in web IDE: Contribute

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #839 (0600725) into main (7d3e0df) will decrease coverage by 0.02%.
The diff coverage is 30.00%.

❗ Current head 0600725 differs from pull request most recent head 5acfe31. Consider uploading reports for the commit 5acfe31 to get more accurate results

@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
- Coverage   81.63%   81.62%   -0.02%     
==========================================
  Files         349      349              
  Lines       35549    35559      +10     
  Branches     2231     2232       +1     
==========================================
+ Hits        29022    29025       +3     
- Misses       6504     6511       +7     
  Partials       23       23              
Flag Coverage Δ
unittests 81.62% <30.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/devworkspaceClient/services/serverConfigApi.ts 74.27% <30.00%> (-2.26%) ⬇️

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-839

@che-bot
Copy link
Contributor

che-bot commented Jun 15, 2023

Click here to review and test in web IDE: Contribute

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Jun 15, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-839

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-839

@che-bot
Copy link
Contributor

che-bot commented Jun 16, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-839

@che-bot
Copy link
Contributor

che-bot commented Jun 16, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-839

@olexii4 olexii4 marked this pull request as ready for review June 16, 2023 10:33
@che-bot
Copy link
Contributor

che-bot commented Jun 16, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-839

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm 👍

@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Jun 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2023

New changes are detected. LGTM label has been removed.

@che-bot
Copy link
Contributor

che-bot commented Jun 19, 2023

Click here to review and test in web IDE: Contribute

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Jun 19, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-839

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-839

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2023

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-dashboard-happy-path 5acfe31 link true /test v11-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@che-bot
Copy link
Contributor

che-bot commented Jun 19, 2023

Click here to review and test in web IDE: Contribute

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jun 19, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-839

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-839

@olexii4 olexii4 merged commit 0d96570 into main Jun 19, 2023
@olexii4 olexii4 deleted the locul_run branch June 19, 2023 17:15
ScrewTSW pushed a commit to ScrewTSW/che-dashboard that referenced this pull request Jul 14, 2023
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants