This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Fix regex used for processing image references #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex we use to update image references used in airgap mode fails if the registry hostname contains a colon. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
requested review from
l0rd,
nickboldt,
rhopp,
skabashnyuk and
vparfonov
as code owners
nickboldt
approved these changes
Oct 25, 2019
ibuziuk
pushed a commit
to ibuziuk/che-devfile-registry
that referenced
this pull request
Oct 28, 2019
The regex we use to update image references used in airgap mode fails if the registry hostname contains a colon. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
ibuziuk
pushed a commit
that referenced
this pull request
Oct 28, 2019
The regex we use to update image references used in airgap mode fails if the registry hostname contains a colon. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
monaka
referenced
this pull request
in PizzaFactory/che-devfile-registry
Nov 25, 2019
The regex we use to update image references used in airgap mode fails if the registry hostname contains a colon. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
monaka
referenced
this pull request
in PizzaFactory/che-devfile-registry
Nov 25, 2019
The regex we use to update image references used in airgap mode fails if the registry hostname contains a colon. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the image regex we use to break an image reference into
repo/org/image:tag. Currently it fails to match if registry hostname contains a port, since it does not match the colon.What issues does this PR fix or reference?
eclipse-che/che#14990