Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Improve airgap support #136

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Conversation

amisevsk
Copy link
Contributor

What does this PR do?

Minor fixes to airgap support

  • In list_referenced_images.sh, get all images, no matter where they're referenced
  • Update all devfiles to list images with registry included.

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming you tested the new yq script and it works for all existing cases, then +1.

- Update all devfile image refs to use registry explicitly (e.g.
  docker.io instead of implicit)
- Update list_referenced_images.sh to list images referenced anywhere
in devfile

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@amisevsk amisevsk merged commit ae6e9ca into eclipse-che:master Oct 31, 2019
@ibuziuk ibuziuk mentioned this pull request Nov 6, 2019
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants