This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Add debug.node.useV3 workspace property #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
vitaliy-guliy
requested review from
benoitf,
ericwill,
JPinkney,
svor,
tsmaeder and
vinokurig
as code owners
JPinkney
approved these changes
Nov 9, 2020
ericwill
approved these changes
Nov 9, 2020
|
Devfiles tests failed. Re-trigger by |
sparkoo
pushed a commit
to sparkoo/che-devfile-registry
that referenced
this pull request
Dec 4, 2020
* Che4z-1.0.0 Signed-off-by: Filip Kroupa <filip.kroupa@broadcom.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com
What does this PR do?
A new version of
ms-vscode/node-debugplugin requiresdebug.node.useV3workspace property set tofalse. Without this property, the debugger cannot connect to the node process.It's better to merge this PR before merging the corresponding PR to che-plugin-registry, but it's not critical.
How to test this PR?
Follow
How to testsection in the PR to plugin registry eclipse-che/che-plugin-registry#666PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.