This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 114
Add a GitHub action based release job #309
Merged
ericwill
merged 3 commits into
eclipse-che:master
from
ericwill:18072_release_job_gh_action
Dec 11, 2020
Merged
Add a GitHub action based release job #309
ericwill
merged 3 commits into
eclipse-che:master
from
ericwill:18072_release_job_gh_action
Dec 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of eclipse-che/che#18072 Signed-off-by: Eric Williams <ericwill@redhat.com>
ericwill
requested review from
benoitf,
JPinkney,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
November 26, 2020 21:39
nickboldt
reviewed
Dec 4, 2020
nickboldt
reviewed
Dec 4, 2020
nickboldt
reviewed
Dec 4, 2020
Signed-off-by: Eric Williams <ericwill@redhat.com>
nickboldt
reviewed
Dec 7, 2020
nickboldt
reviewed
Dec 7, 2020
nickboldt
reviewed
Dec 7, 2020
nickboldt
reviewed
Dec 7, 2020
Signed-off-by: Eric Williams <ericwill@redhat.com>
nickboldt
approved these changes
Dec 7, 2020
9 tasks
About the secrets, you can add the secret via GitHub API like so: https://developer.github.com/v3/actions/secrets/#create-or-update-a-repository-secret There is an automated way to do it (thanks to @benoitf), just make sure you change the |
As I'm not privy to the values of these secrets, and can't copy them from another eclipse/che-* repo (I'm not an admin)... I'll ask that someone like @benoitf runs his script and pushes the secrets to this and teh che-plugin-registry repo too. If feeling particularly bored, could repeat the same steps for all the other repos that need to be migrated to GH action from centos ci: eclipse-che/che#17857 |
vitaliy-guliy
approved these changes
Dec 8, 2020
This was referenced Dec 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Williams ericwill@redhat.com
What does this PR do?
Adds a GitHub action based release job system to the devfile registry.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Part of eclipse-che/che#18072
How to test this PR?
Modify the VERSION file on the
release
branch and push the changes.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.