This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Multiarch build support by docker buildx #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhav-thali
requested review from
benoitf,
ericwill,
JPinkney,
sunix,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
ericwill
reviewed
Jan 5, 2021
Signed-off-by: Prabhav Thali <Prabhav.Thali1@ibm.com>
prabhav-thali
force-pushed
the
GA-buildx
branch
from
a3339a6 to
5b5f74c
Compare
ericwill
approved these changes
Jan 6, 2021
|
Let's give it a shot |
benoitf
reviewed
Jan 7, 2021
| context: . | ||
| file: ./build/dockerfiles/Dockerfile | ||
| target: registry | ||
| platforms: linux/amd64,linux/s390x |
There was a problem hiding this comment.
we're missing 2 arches there: ppc64le and arm64
benoitf
reviewed
Jan 7, 2021
| context: . | ||
| file: ./build/dockerfiles/Dockerfile | ||
| target: registry | ||
| platforms: linux/amd64,linux/s390x |
There was a problem hiding this comment.
looks like platforms should be a constant or a file like PLATFORMS in root repository to avoid copy/paste
benoitf
reviewed
Jan 7, 2021
|
|
||
| - name: 'Docker Prepare' | ||
| run: docker image prune -a -f |
There was a problem hiding this comment.
why do we need to remove other images ? we're missing some spaces ?
if not we could keep them to not slow down
monaka
pushed a commit
to PizzaFactory/che-devfile-registry
that referenced
this pull request
Jan 22, 2021
Signed-off-by: Prabhav Thali <Prabhav.Thali1@ibm.com>
This was referenced Feb 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables docker buildx support in GitHub Actions job to build and publish multiarch docker images. All the workflows (nightly build, PR check, and release) are updated to have multiarch support.
What issues does this PR fix or reference?
This refers to #17124. As per @nickboldt's comment on #250, raised this PR to add multiarch support.