This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
feat: Update zip location for prebuilt samples with internal URL #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It avoids proxy/TLS/untrusted issue related to eclipse-che/che#20709 Change-Id: Ic39fa9928c4f86ff4543117a9092f0cadb0457bd Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
JPinkney,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
|
Click here to review and test in web IDE: |
svor
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Works as expected, thanks!
bash-5.0$ wget http://devfile-registry.eclipse-che.svc:8080/resources/v2/golang-echo-example.zip
Connecting to devfile-registry.eclipse-che.svc:8080 (172.30.58.176:8080)
saving to 'golang-echo-example.zip'
golang-echo-example. 100% |**********************************************************************************************************************| 72188 0:00:00 ETA
'golang-echo-example.zip' saved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It avoids proxy/TLS/untrusted issue
related to eclipse-che/che#20709
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20709
How to test this PR?
(make sure your che operator is the nightly one including this fix: eclipse-che/che-operator#1237)
Then open devfile registry with a browser to something like
https://che-url/devfile-registry/devfiles/go/devworkspace-che-theia-latest.yamlsee that the zip location is using
http://devfile-registry.eclipse-che.svc:8080/resources/v2/golang-echo-example.zipYou can go inside for example dashboard container and do:
file is downloaded as expected
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Change-Id: Ic39fa9928c4f86ff4543117a9092f0cadb0457bd
Signed-off-by: Florent Benoit fbenoit@redhat.com