Setup Che in TLS mode with self-signed certificates #1007

mshaposhnik · 2020-01-02T08:18:39Z

What does this PR do?

Documenting how to setup Che with TLS with self-signed certificate for development.

What issues does this PR fix or reference?

eclipse-che/che#15301

Signed-off-by: mshaposh <mshaposh@redhat.com>

skabashnyuk · 2020-01-03T08:16:24Z

CC @tolusha

tolusha · 2020-01-03T08:27:33Z

/cc @mmorhun

Signed-off-by: Michal Vala <mvala@redhat.com>

* add crc domain Signed-off-by: Michal Vala <mvala@redhat.com> * link to browser import Signed-off-by: Michal Vala <mvala@redhat.com>

* add crc domain Signed-off-by: Michal Vala <mvala@redhat.com> * link to browser import Signed-off-by: Michal Vala <mvala@redhat.com> * added some links to better orientation and minor tweaks Signed-off-by: Michal Vala <mvala@redhat.com>

sparkoo · 2020-01-03T14:28:46Z

@mshaposhnik I'm ok with current state. Can we switch PR from draft?

src/main/pages/che-7/installation-guide/proc_deploy-che-with-self-signed-tls-on-kubernetes.adoc

src/main/pages/che-7/installation-guide/proc_che-usage-with-tls.adoc

src/main/pages/che-7/installation-guide/proc_gerenating-self-signed-certificates.adoc

* add crc domain Signed-off-by: Michal Vala <mvala@redhat.com> * link to browser import Signed-off-by: Michal Vala <mvala@redhat.com> * added some links to better orientation and minor tweaks Signed-off-by: Michal Vala <mvala@redhat.com> * added OSX example Signed-off-by: Michal Vala <mvala@redhat.com> * system-wide note Signed-off-by: Michal Vala <mvala@redhat.com>

* add crc domain Signed-off-by: Michal Vala <mvala@redhat.com> * link to browser import Signed-off-by: Michal Vala <mvala@redhat.com> * added some links to better orientation and minor tweaks Signed-off-by: Michal Vala <mvala@redhat.com> * added OSX example Signed-off-by: Michal Vala <mvala@redhat.com> * system-wide note Signed-off-by: Michal Vala <mvala@redhat.com> * Revert "system-wide note" This reverts commit 00ed96c.

Signed-off-by: Michal Vala <mvala@redhat.com>

* add crc domain Signed-off-by: Michal Vala <mvala@redhat.com> * link to browser import Signed-off-by: Michal Vala <mvala@redhat.com> * added some links to better orientation and minor tweaks Signed-off-by: Michal Vala <mvala@redhat.com> * added OSX example Signed-off-by: Michal Vala <mvala@redhat.com> * system-wide note Signed-off-by: Michal Vala <mvala@redhat.com> * Revert "system-wide note" This reverts commit 00ed96c. * revert system-wide note Signed-off-by: Michal Vala <mvala@redhat.com> * OSX rootCA import Signed-off-by: Michal Vala <mvala@redhat.com>

src/main/pages/che-7/installation-guide/proc_gerenating-self-signed-certificates.adoc

* sha256 Signed-off-by: Michal Vala <mvala@redhat.com>

* update docs for crc * update navigation Signed-off-by: Michal Vala <mvala@redhat.com>

mmorhun

LGTM

...es/che-7/installation-guide/assembly_setup-che-in-tls-mode-with-self-signed-certificate.adoc

* add keywords to tls docs Signed-off-by: Michal Vala <mvala@redhat.com>

skabashnyuk · 2020-01-08T08:41:09Z

@rkratky asked me about since it's for devel purposes, can we find a place for it in the Contributor Guide?

@sparkoo for TLS docs https://github.com/eclipse/che/wiki this is imho not the right place, there is basically nothing technical about development. Another candidate is this https://github.com/eclipse/che/blob/master/CONTRIBUTING.md also this Contributor guide on che-docs https://github.com/eclipse/che-docs/tree/master/src/main/pages/che-7/contributor-guide

@tolusha For me it is part of installation guide

sparkoo · 2020-01-09T06:29:14Z

It would be nice to have a place where we can share knowledge about development (setup, deploy, build, test, debug, various tips etc.) without any formal ceremonies like reviews. Pure informal knowledge base.

For now, I'm +1 for Contributor guide in che-docs https://github.com/eclipse/che-docs/tree/master/src/main/pages/che-7/contributor-guide

skabashnyuk · 2020-01-09T08:22:15Z

@rkratky @themr0c @slemeur @tolusha @l0rd wdyt about to move this content to https://github.com/eclipse/che-docs/tree/master/src/main/pages/che-7/contributor-guide ?

themr0c · 2020-01-09T11:40:00Z

One good point for the Contribution guide is: it is not used downstream.

We will end up having documents explaining how to install Che in: Overview > Che quick-starts, Installation guide, and Contribution guide, but I believe it is quite OK as each user story has specific requirements. I wonder if some parts could be reused.

sparkoo · 2020-01-15T09:58:05Z

From our side, content is complete and we're not currently actively working on this. Remaining question is what is proper place for this doc? Can someone from docs team please comment on this and review the changeset?
cc: @themr0c @rkratky

sparkoo · 2020-01-27T13:23:47Z

@themr0c I've moved the doc under the contributor's guide. Any other comment?

mshaposhnik and others added 5 commits December 24, 2019 08:52

Add assembly for tls-docs

90e1a2d

Added tls certs generation procedure

a27159f

Signed-off-by: mshaposh <mshaposh@redhat.com>

Continue providing tls docs

4928dae

Minor fixes

ec22099

TLS docs update (#1008)

11aa5f3

mshaposhnik and others added 4 commits January 3, 2020 09:31

add openshift 4 doc

fcad6f5

add crc domain

785c069

Signed-off-by: Michal Vala <mvala@redhat.com>

Tls docs (#1010)

f9494b8

* add crc domain Signed-off-by: Michal Vala <mvala@redhat.com> * link to browser import Signed-off-by: Michal Vala <mvala@redhat.com>

Tls docs (#1011)

976f849

* add crc domain Signed-off-by: Michal Vala <mvala@redhat.com> * link to browser import Signed-off-by: Michal Vala <mvala@redhat.com> * added some links to better orientation and minor tweaks Signed-off-by: Michal Vala <mvala@redhat.com>

mshaposhnik marked this pull request as ready for review January 3, 2020 14:34

mshaposhnik requested review from rkratky, slemeur and themr0c as code owners January 3, 2020 14:34

skabashnyuk reviewed Jan 6, 2020

View reviewed changes

src/main/pages/che-7/installation-guide/proc_deploy-che-with-self-signed-tls-on-kubernetes.adoc Outdated Show resolved Hide resolved

skabashnyuk reviewed Jan 6, 2020

View reviewed changes

src/main/pages/che-7/installation-guide/proc_che-usage-with-tls.adoc Outdated Show resolved Hide resolved

skabashnyuk reviewed Jan 6, 2020

View reviewed changes

src/main/pages/che-7/installation-guide/proc_gerenating-self-signed-certificates.adoc Outdated Show resolved Hide resolved

sparkoo added 4 commits January 6, 2020 13:30

Tls docs (#1015)

80a3447

Signed-off-by: Michal Vala <mvala@redhat.com>

sparkoo mentioned this pull request Jan 6, 2020

Tls docs #1016

Merged

skabashnyuk reviewed Jan 6, 2020

View reviewed changes

src/main/pages/che-7/installation-guide/proc_gerenating-self-signed-certificates.adoc Outdated Show resolved Hide resolved

sparkoo added 2 commits January 6, 2020 15:23

Tls docs (#1018)

dfa724c

* sha256 Signed-off-by: Michal Vala <mvala@redhat.com>

Tls docs (#1021)

2684c6a

* update docs for crc * update navigation Signed-off-by: Michal Vala <mvala@redhat.com>

skabashnyuk approved these changes Jan 7, 2020

View reviewed changes

sparkoo self-assigned this Jan 8, 2020

mmorhun approved these changes Jan 8, 2020

View reviewed changes

...es/che-7/installation-guide/assembly_setup-che-in-tls-mode-with-self-signed-certificate.adoc Outdated Show resolved Hide resolved

Tls docs (#1023)

62f7b54

* add keywords to tls docs Signed-off-by: Michal Vala <mvala@redhat.com>

sparkoo requested review from sparkoo and removed request for sparkoo January 8, 2020 08:27

johnmcollier mentioned this pull request Jan 10, 2020

[HTTPS] Using Che with self-signed-certs on OpenShift is frustrating. eclipse-che/che#15658

Closed

sparkoo closed this Jan 15, 2020

sparkoo reopened this Jan 15, 2020

che-bot added status/code-review kind/task labels Jan 15, 2020

sparkoo approved these changes Jan 21, 2020

View reviewed changes

move tls with self-signed cert into contributor's guide (#1056)

8c8c5e7

themr0c merged commit c1866ff into master Jan 29, 2020

che-bot removed the status/code-review label Jan 29, 2020

themr0c deleted the tls_docs branch March 12, 2020 07:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup Che in TLS mode with self-signed certificates #1007

Setup Che in TLS mode with self-signed certificates #1007

mshaposhnik commented Jan 2, 2020 •

edited by sparkoo

Loading

skabashnyuk commented Jan 3, 2020

tolusha commented Jan 3, 2020

sparkoo commented Jan 3, 2020

mmorhun left a comment

skabashnyuk commented Jan 8, 2020

sparkoo commented Jan 9, 2020

skabashnyuk commented Jan 9, 2020 •

edited

Loading

themr0c commented Jan 9, 2020

sparkoo commented Jan 15, 2020

sparkoo commented Jan 27, 2020

Setup Che in TLS mode with self-signed certificates #1007

Setup Che in TLS mode with self-signed certificates #1007

Conversation

mshaposhnik commented Jan 2, 2020 • edited by sparkoo Loading

What does this PR do?

What issues does this PR fix or reference?

skabashnyuk commented Jan 3, 2020

tolusha commented Jan 3, 2020

sparkoo commented Jan 3, 2020

mmorhun left a comment

Choose a reason for hiding this comment

skabashnyuk commented Jan 8, 2020

sparkoo commented Jan 9, 2020

skabashnyuk commented Jan 9, 2020 • edited Loading

themr0c commented Jan 9, 2020

sparkoo commented Jan 15, 2020

sparkoo commented Jan 27, 2020

mshaposhnik commented Jan 2, 2020 •

edited by sparkoo

Loading

skabashnyuk commented Jan 9, 2020 •

edited

Loading