Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPU limis/request into plugin container description #1079

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Add CPU limis/request into plugin container description #1079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ...er-guide/proc_writing-a-meta-yaml-file-and-adding-it-to-a-plug-in-registry.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ spec:
containers: <12>
- image: <13>
memoryLimit: <14>
extensions: <15>
memoryRequest: <15>
cpuLimit: <16>
cpuRequest: <17>
extensions: <18>
- https://github.com/redhat-developer/vscode-yaml/releases/download/0.4.0/redhat.vscode-yaml-0.4.0.vsix
- vscode:extension/SonarSource.sonarlint-vscode
----
Expand All @@ -45,5 +48,8 @@ spec:
<11> Defines the category that this plug-in belongs to. Should be one of the following: `Editor`, `Debugger`, `Formatter`, `Language`, `Linter`, `Snippet`, `Theme`, or `Other`.
<12> If this section is omitted, the VS Code extension is added into the Che-Theia IDE container.
<13> The Docker image from which the sidecar container will be started. Example: `eclipse/che-theia-endpoint-runtime:next`.
<14> The RAM which is given for the sidecar container by default. Example: "256Mi". This value might be overridden by the user in the component configuration.
<15> A list of VS Code extensions that should be run in this sidecar container.
<14> The maximum RAM which is available for the sidecar container. Example: "512Mi". This value might be overridden by the user in the component configuration.
<15> The RAM which is given for the sidecar container by default. Example: "256Mi". This value might be overridden by the user in the component configuration.
<16> The maximum CPU amount in cores or millicores (suffixed with "m") which is available for the sidecar container. Examples: "500m", "2". This value might be overridden by the user in the component configuration.
<17> The CPU amount in cores or millicores (suffixed with "m") which is given for the sidecar container by default. Example: "125m". This value might be overridden by the user in the component configuration.
<18> A list of VS Code extensions that should be run in this sidecar container.
5 changes: 4 additions & 1 deletion src/main/pages/che-7/end-user-guide/ref_che-theia-plug-in-metadata.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ The link:https://github.com/eclipse/che-plugin-registry/tree/master/v3/plugins[c
:===
`name`: sidecar container name
`image`: container image
`memorylimit`: Kubernetes/OpenShift-spec memory limit string (e.g. "512Mi")
`memoryLimit`: Kubernetes/OpenShift-spec memory limit string (e.g. "512Mi")
`memoryRequest`: Kubernetes/OpenShift-spec memory request string (e.g. "512Mi")
`cpuLimit`: Kubernetes/OpenShift-spec CPU limit string (e.g. "2500m")
`cpuRequest`: Kubernetes/OpenShift-spec CPU request string (e.g. "125m")
`env`: list of environment variables to set in sidecar
`command`: string array definition of the root process command inside container.
`args`: string array arguments for the root process command inside container
Expand Down