Move "Customizing the registries" to the Contributor guide #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move "Editing a devfile and plug-in at runtime" to the End-User guide * Modularize "Customizing the registries", reusing "Building offline images" * Follow conventions for file names
themr0c
requested review from
yhontyk,
l0rd,
MichalMaler and
rkratky
as code owners
|
|
|
Vale: improvements but not fixed everything. |
…the End-user Guide
|
@themr0c, this looks good (based on the screenshots), but one nitpick: let's unify the headings with what's in the navig menu. |
|
|
rkratky
approved these changes
Oct 9, 2020
themr0c
added a commit
that referenced
this pull request
Oct 12, 2020
* Move "Customizing the registries" to the Contributor guide * Move "Editing a devfile and plug-in at runtime" to the End-User guide * Modularize "Customizing the registries", reusing "Building offline images" * Follow conventions for file names * Move images * Move Adding a VSCode extension and Publishing a VS Code extension to the End-user Guide * Consistency and fixes
themr0c
added a commit
that referenced
this pull request
Oct 27, 2020
* Move "Customizing the registries" to the Contributor guide * Move "Editing a devfile and plug-in at runtime" to the End-User guide * Modularize "Customizing the registries", reusing "Building offline images" * Follow conventions for file names * Move images * Move Adding a VSCode extension and Publishing a VS Code extension to the End-user Guide * Consistency and fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: eclipse-che/che#17510
PR Checklist
As the author of this Pull Request I made sure that:
valehas been run successfully against the PR branch