Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s.tlsSecretName property behaviour doc #1687

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Update k8s.tlsSecretName property behaviour doc #1687

merged 2 commits into from
Nov 24, 2020

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Nov 4, 2020

Signed-off-by: Mykola Morhun mmorhun@redhat.com

Read our Contribution guide before submitting a PR.

What does this PR do?

Updates docs regarding k8s.tlsSecretName CR field property.

What issues does this PR fix or reference?

eclipse-che/che#18079

Specify the version of the product this PR applies to.

Since merge of eclipse-che/che-operator#508

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successfully against the PR branch
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • Changed article references are updated where they are used (or a redirect has been set up on the docs side):

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
…urce-fields-reference.adoc

Co-authored-by: Yana Hontyk <yhontyk@redhat.com>
@mmorhun
Copy link
Contributor Author

mmorhun commented Nov 4, 2020

@boczkowska thank you for the corrections. However vale check is still failing because of words if and should. Deleting them and rewording looks artificial for me. What is the right procedure in such a case?

@yhontyk yhontyk self-requested a review November 4, 2020 14:52
Copy link

@yhontyk yhontyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmorhun I find the use of if and should to be correct and acceptable here. I'll file an issue to tune those vale rules.

I'll approve the PR, please merge when ready. Note that currently we publish 7.21 docs from the master branch. If it applies to the future release, we'll have to wait until the next release is GA.

@tolusha tolusha mentioned this pull request Nov 5, 2020
46 tasks
@mmorhun mmorhun merged commit 3bcffca into master Nov 24, 2020
@mmorhun mmorhun deleted the che-18079 branch November 24, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants