Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

procedures: Setting Authorization callback URL in GitHub OAuth app to Che OAuth callback URL #2177

Merged
merged 12 commits into from
Dec 8, 2021

Conversation

xbaran4
Copy link
Contributor

@xbaran4 xbaran4 commented Dec 3, 2021

Signed-off-by: Pavol Baran pbaran@redhat.com

What does this pull request change?

Add a point explaing what Authorization callback URL to use when creating GitHub OAuth app to authorize Che and Che is deployed with native auth.

Any changes to wording or grammar are welcome.

What issues does this pull request fix or reference?

eclipse-che/che#20873

Specify the version of the product this pull request applies to

next

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Signed-off-by: Pavol Baran <pbaran@redhat.com>
@xbaran4 xbaran4 requested review from rkratky, themr0c and a team as code owners December 3, 2021 07:28
@xbaran4 xbaran4 requested a review from tolusha December 3, 2021 07:28
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@max-cx max-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, a few questions and one suggested change to begin with.

skabashnyuk and others added 3 commits December 7, 2021 11:09
…oauth.adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>
…oauth.adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>
…oauth.adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>
skabashnyuk and others added 3 commits December 7, 2021 17:01
…oauth.adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>
…oauth.adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>
…oauth.adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>
skabashnyuk and others added 2 commits December 7, 2021 17:36
…oauth.adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>
…oauth.adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>
@max-cx
Copy link
Contributor

max-cx commented Dec 7, 2021

@themr0c, I approved after suggested changes.

@themr0c themr0c merged commit 1f1ceaa into eclipse-che:master Dec 8, 2021
@themr0c themr0c added this to the 7.41 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants