Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken link #2185

Merged
merged 4 commits into from
Dec 9, 2021
Merged

fix: broken link #2185

merged 4 commits into from
Dec 9, 2021

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Dec 7, 2021 •
edited
Loading

Fix a broken link

htmltest
docs/che-7/installation-guide/installing-che-on-aws/index.html
  Get "http://che.aws.my-ide.cloud": dial tcp: lookup che.aws.my-ide.cloud: no such host --- docs/che-7/installation-guide/installing-che-on-aws/index.html --> http://che.aws.my-ide.cloud

@themr0c themr0c requested review from rkratky and a team as code owners December 7, 2021 18:33
@themr0c themr0c requested a review from benoitf December 7, 2021 18:33
@themr0c themr0c added this to the 7.40 milestone Dec 7, 2021
@themr0c themr0c self-assigned this Dec 7, 2021
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Click here to review and test in web IDE: Contribute

max-cx
max-cx requested changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@max-cx max-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might make it a bit clearer.

modules/installation-guide/partials/proc_preparing-the-aws-system-for-installing-che.adoc Outdated Show resolved Hide resolved
@themr0c themr0c merged commit 09d0b8c into master Dec 9, 2021
@themr0c themr0c deleted the fix-broken-link branch December 9, 2021 16:19
themr0c added a commit that referenced this pull request Dec 10, 2021
@themr0c @nickboldt @max-cx
fix: broken link (#2185)
e9046bd 
* fix: broken link

* Update modules/installation-guide/partials/proc_preparing-the-aws-system-for-installing-che.adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>

Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Max Leonov <mleonov@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-cx max-cx max-cx requested changes

@benoitf benoitf benoitf approved these changes

@rkratky rkratky rkratky approved these changes

Assignees

@themr0c themr0c

@rkratky rkratky

Labels
cherry-picked to 7.40.x kind/bug
Projects
None yet
Milestone
7.40
Development

Successfully merging this pull request may close these issues.
6 participants
@themr0c @benoitf @rkratky @max-cx @che-bot @nickboldt