-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: mounting volumes, secrets and configmaps for devworkspaces #2296
Conversation
6df6bb4
to
9b7459c
Compare
Signed-off-by: David Kwon <dakwon@redhat.com>
9b7459c
to
68ac170
Compare
I will review this PR. |
Thank you @max-cx, I've edited the PR description to provide some context |
modules/end-user-guide/pages/mounting-volumes-secrets-and-configmaps.adoc
Outdated
Show resolved
Hide resolved
modules/end-user-guide/pages/mounting-volumes-secrets-and-configmaps.adoc
Outdated
Show resolved
Hide resolved
modules/end-user-guide/pages/mounting-configmaps-and-secrets.adoc
Outdated
Show resolved
Hide resolved
modules/end-user-guide/pages/mounting-volumes-secrets-and-configmaps.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having one main section "mounting volumes, secrets and configmaps" I would split like this:
- Injecting configurations and credentials (that's about CM, Secrets)
a. Configuring git
b. Configuring container registries - Persisting and sharing files (that's about pre created PVs)
modules/end-user-guide/pages/mounting-volumes-secrets-and-configmaps.adoc
Outdated
Show resolved
Hide resolved
modules/end-user-guide/pages/mounting-volumes-secrets-and-configmaps.adoc
Outdated
Show resolved
Hide resolved
modules/end-user-guide/pages/mounting-configmaps-and-secrets.adoc
Outdated
Show resolved
Hide resolved
modules/end-user-guide/pages/mounting-configmaps-and-secrets.adoc
Outdated
Show resolved
Hide resolved
modules/end-user-guide/pages/mounting-configmaps-and-secrets.adoc
Outdated
Show resolved
Hide resolved
* review
0b44b86
to
d2284db
Compare
d2284db
to
6ea77a5
Compare
6eb7c3d
to
85a848a
Compare
85a848a
to
f902a91
Compare
Signed-off-by: dakwon <dakwon@redhat.com>
f902a91
to
2ad5896
Compare
@dkwon17, my next PR is ready dkwon17#11 |
* review
Signed-off-by: David Kwon <dakwon@redhat.com>
I don't think the current build failure is caused by this PR. I get the same failure in the master branch:
|
adb4ea8
to
1f39963
Compare
Signed-off-by: David Kwon <dakwon@redhat.com>
1f39963
to
94443fc
Compare
@dkwon17, pls see more edits from me in the form of dkwon17#13. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: David Kwon <dakwon@redhat.com>
Signed-off-by: David Kwon dakwon@redhat.com
What does this pull request change
Creating image pull Secrets
sectionBefore this PR:
After this PR:
Sources used:
do
What issues does this pull request fix or reference
eclipse-che/che#21299
Specify the version of the product this pull request applies to
Pull request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.