-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update proc_setting-up-the-microsoft-azure-devops-services-oauth-app.… #2623
base: main
Are you sure you want to change the base?
Conversation
…adoc docs: Adding a step to Authorize access to the application with OAuth 2.0
⚡️ Deploying pull request preview... |
...nistration-guide/partials/proc_setting-up-the-microsoft-azure-devops-services-oauth-app.adoc
Outdated
Show resolved
Hide resolved
@satyamburhade thank you for the contribution, please sign the https://www.eclipse.org/legal/ECA.php so that we could merge the PR |
…osoft-azure-devops-services-oauth-app.adoc Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com>
@ibuziuk I've signed the ECA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satyamburhade Actually, I'm not sure we should change the link title since https://learn.microsoft.com/en-us/azure/devops/integrate/get-started/authentication/oauth?view=azure-devops has the "Authorize access to REST APIs with OAuth 2.0" which is already set correctly in the doc. wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satyamburhade Actually, I'm not sure we should change the link title since https://learn.microsoft.com/en-us/azure/devops/integrate/get-started/authentication/oauth?view=azure-devops has the "Authorize access to REST APIs with OAuth 2.0" which is already set correctly in the doc. wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping the link in Additional resources
and adding a step
@tolusha @vinokurig folks, could you please review? Not sure if this step is required |
@@ -46,6 +46,8 @@ $ echo -n '__<microsoft_azure_devops_services_oauth_app_id>__' | base64 | |||
$ echo -n '__<microsoft_azure_devops_services_oauth_client_secret>__' | base64 | |||
---- | |||
|
|||
. Make sure to authorize the application when Azure DevOps Services presents the authorization approval page to a user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satyamburhade
Actually I didn't face anything that requires approval.
Could you show some screenshots for better understanding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got what you meant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is NOT related to the Admin, see #2624
…adoc
docs: Adding a step to Authorize access to the application with OAuth 2.0
What does this pull request change?
What issues does this pull request fix or reference?
Specify the version of the product this pull request applies to
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.