Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ensure that githost contains URL but not just hostname #2638

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Aug 10, 2023

What does this pull request change?

chore: Ensure that githost contains URL but not just hostname
Based on https://redhat-internal.slack.com/archives/C011LSD1R4M/p1691527680397479

What issues does this pull request fix or reference?

N/A

Specify the version of the product this pull request applies to

main

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha requested review from rkratky, max-cx, deerskindoll and a team as code owners August 10, 2023 08:19
@tolusha tolusha requested a review from ibuziuk August 10, 2023 08:19
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

🎊 Navigate the preview: https://64db5abacb9ad6504abf8df3--eclipse-che-docs-pr.netlify.app 🎊

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha changed the title chore: Ensure that contains URL but not just hostname chore: Ensure that githost contains URL but not just hostname Aug 10, 2023
…for-git-repositories-with-self-signed-certificates.adoc

Co-authored-by: Ilya Buziuk <ibuziuk@redhat.com>
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tolusha tolusha merged commit b2a9256 into main Aug 14, 2023
@tolusha tolusha deleted the improvegitdoc branch August 14, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants