-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Restore installing image puller on openshift using cli #2722
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
🎊 Navigate the preview: https://662a6c88a40998cf72a19347--eclipse-che-docs-pr.netlify.app 🎊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix for the antora issue and a couple of suggestions
modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc
Outdated
Show resolved
Hide resolved
…openshift-using-cli.adoc Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…openshift-using-cli.adoc Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…openshift-using-cli.adoc Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to add space, sorry
modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc
Outdated
Show resolved
Hide resolved
…openshift-using-cli.adoc
@tolusha I finally realized why the antora check is failing. you forgot to update nav.adoc with the new doc. the build won't pass until you do that. |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
* chore: Restore installing image puller on openshift using cli Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com> * Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com> * Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com> * Adress remarks Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc * Update nav.adoc Signed-off-by: Anatolii Bazko <abazko@redhat.com> --------- Signed-off-by: Anatolii Bazko <abazko@redhat.com> Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
* chore: Restore installing image puller on openshift using cli Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com> * Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com> * Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com> * Adress remarks Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc * Update nav.adoc Signed-off-by: Anatolii Bazko <abazko@redhat.com> --------- Signed-off-by: Anatolii Bazko <abazko@redhat.com> Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
What does this pull request change?
chore: Restore installing image puller on openshift using cli
What issues does this pull request fix or reference?
https://issues.redhat.com/browse/CRW-5723
Specify the version of the product this pull request applies to
7.84.x
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.