Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Restore installing image puller on openshift using cli #2722

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Apr 23, 2024

What does this pull request change?

chore: Restore installing image puller on openshift using cli

What issues does this pull request fix or reference?

https://issues.redhat.com/browse/CRW-5723

Specify the version of the product this pull request applies to

7.84.x

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha requested review from deerskindoll and a team as code owners April 23, 2024 10:59
@tolusha tolusha requested a review from azatsarynnyy April 23, 2024 10:59
Copy link

github-actions bot commented Apr 23, 2024

🎊 Navigate the preview: https://662a6c88a40998cf72a19347--eclipse-che-docs-pr.netlify.app 🎊

Copy link

github-actions bot commented Apr 23, 2024

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix for the antora issue and a couple of suggestions

tolusha and others added 4 commits April 24, 2024 13:59
…openshift-using-cli.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…openshift-using-cli.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…openshift-using-cli.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to add space, sorry

@deerskindoll
Copy link
Contributor

@tolusha I finally realized why the antora check is failing. you forgot to update nav.adoc with the new doc. the build won't pass until you do that.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@deerskindoll deerskindoll merged commit 75796a6 into main Apr 25, 2024
9 of 10 checks passed
@deerskindoll deerskindoll deleted the CRW-5723_2 branch April 25, 2024 17:55
deerskindoll added a commit that referenced this pull request Apr 25, 2024
* chore: Restore installing image puller on openshift using cli

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>

* Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>

* Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>

* Adress remarks

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc

* Update nav.adoc

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

---------

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
deerskindoll added a commit that referenced this pull request Apr 25, 2024
* chore: Restore installing image puller on openshift using cli

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>

* Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>

* Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>

* Adress remarks

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Update modules/administration-guide/pages/installing-image-puller-on-openshift-using-cli.adoc

* Update nav.adoc

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

---------

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants