Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Override workspace base domain #2826

Merged
merged 3 commits into from
Nov 22, 2024
Merged

feat: Override workspace base domain #2826

merged 3 commits into from
Nov 22, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Nov 22, 2024

What does this pull request change?

feat: Override workspace base domain article

What issues does this pull request fix or reference?

eclipse-che/che#23249

Specify the version of the product this pull request applies to

main

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha requested review from deerskindoll and a team as code owners November 22, 2024 08:25
@tolusha tolusha requested a review from amisevsk November 22, 2024 08:25
Copy link

github-actions bot commented Nov 22, 2024

🎊 Navigate the preview: https://6740a518ae41bcc9996cbce1--eclipse-che-docs-pr.netlify.app 🎊

Copy link

github-actions bot commented Nov 22, 2024

Click here to review and test in web IDE: Contribute

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small tweak

…oints-base-domain.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants