Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for PHP Debugging #37

Merged
merged 3 commits into from
Jan 6, 2017

Conversation

kaloyan-raev
Copy link
Contributor

Signed-off-by: Kaloyan Raev kaloyan.r@zend.com

Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
@kaloyan-raev
Copy link
Contributor Author

@bartlomiej-laczkowski Please review the content.

Copy link
Contributor

@JamesDrummond JamesDrummond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still rewriting our docs so you probably used same format that was on the markdown :). However, the format for internal image links will in form of ![]({{base}}{{site.links[""]}}).

1. Change any settings if necessary. The defaults are usually OK.
1. Click the `Debug` button.

![php-debug-configuration.png]({{ base }}/docs/assets/imgs/php-debug-configuration.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change to ![php-debug-configuration.png]({{base}}{{site.links["php-debug-configuration.png"]}})


In the end the zDebug settings should look like this:

![zdebug-settings.png]({{ base }}/docs/assets/imgs/zdebug-settings.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change to ![zdebug-settings.pngg]({{ base }}{{site.links["zdebug-settings.png"]}})


In the end the toolbar settings should look like this:

![zend-debugger-firefox-settings.png]({{ base }}/docs/assets/imgs/zend-debugger-firefox-settings.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change to ![zend-debugger-firefox-settings.png]({{ base }}{{site.links["zend-debugger-firefox-settings.png"]}})

1. Click on the "bug" button.
1. Click on `Debug current page`.

![z-ray-debug.png]({{ base }}/docs/assets/imgs/z-ray-debug.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change to ![z-ray-debug.png]({{ base }}{{site.links["z-ray-debug.png"]}})

Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
@kaloyan-raev
Copy link
Contributor Author

@JamesDrummond I changed the image links to the correct format.

@slemeur
Copy link
Contributor

slemeur commented Jan 6, 2017

@kaloyan-raev Is it approved by @bartlomiej-laczkowski ? I'd like to merge the PR so we can update the docs on Che's website and in the product

@kaloyan-raev
Copy link
Contributor Author

Today is a holiday in Poland, so I doubt @bartlomiej-laczkowski will be able to take a look at it before Monday. @slemeur if you a in a hurry, you can merge it now. We can have another PR for any additional changes.

@bartlomiej-laczkowski
Copy link

@kaloyan-raev @slemeur
Indeed, there is a holiday in Poland :) Anyway +1 from me. Looks great, thanks Kaloyan!

@slemeur
Copy link
Contributor

slemeur commented Jan 6, 2017

Thanks a lot guys :) !
Happy holiday !

@slemeur slemeur merged commit d135bdb into eclipse-che:master Jan 6, 2017
JamesDrummond pushed a commit that referenced this pull request Apr 2, 2017
#37)

* Fix link issues. Fix favicon and awesome font by removing filtering from build.

* Embed jquery so https and offline docs work. Set filtering to false to get favicon working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants