-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Che 7: Using a Visual Studio Code extension in Che #754
Che 7: Using a Visual Studio Code extension in Che #754
Conversation
@rkratky @supriya-bharadwaj There seems to be an issue with converting level 3 headings; after rendering, they look like as a plain text. |
...ages/che-7/hands-on-guidance/proc_importing-a-vs-code-extension-in-the-che-theia-editor.adoc
Outdated
Show resolved
Hide resolved
...ages/che-7/hands-on-guidance/proc_importing-a-vs-code-extension-in-the-che-theia-editor.adoc
Outdated
Show resolved
Hide resolved
[discrete] | ||
== Prerequisites | ||
|
||
* Configure the Che Theia memory limit with 512 MB RAM or more to run the Theia editor. In addition, reserve another 512 MB RAM for the VS Code extensions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Configure the Che Theia memory limit with 512 MB RAM or more to run the Theia editor. In addition, reserve another 512 MB RAM for the VS Code extensions. | |
* Configure the Che Theia memory limit with 512 MB RAM or more to run the Theia editor. In addition, reserve an additional 512 MB RAM for the VS Code extensions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichalMaler , the original document does not speak about the additional 512 MB RAM. Can you please confirm that that's what we need here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@supriya-bharadwaj Hello! I fix this by rewriting into this shape:
"Configure the Che Theia memory limit with 512 MB RAM or more to run the Theia editor. In addition, reserve sufficient memory for the VS code extensions. The specific amount of memory required depends on the extensions used."
[discrete] | ||
== Prerequisites | ||
|
||
* Configure the Che Theia memory limit with 512 MB RAM or more to run the Theia editor. In addition, reserve another 512 MB RAM for the VS Code extensions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichalMaler , the original document does not speak about the additional 512 MB RAM. Can you please confirm that that's what we need here?
...ages/che-7/hands-on-guidance/proc_importing-a-vs-code-extension-in-the-che-theia-editor.adoc
Outdated
Show resolved
Hide resolved
...ages/che-7/hands-on-guidance/proc_importing-a-vs-code-extension-in-the-che-theia-editor.adoc
Outdated
Show resolved
Hide resolved
...ages/che-7/hands-on-guidance/proc_importing-a-vs-code-extension-in-the-che-theia-editor.adoc
Outdated
Show resolved
Hide resolved
...e-7/hands-on-guidance/proc_writing-a-meta-yaml-file-and-adding-it-to-a-plug-in-registry.adoc
Outdated
Show resolved
Hide resolved
src/main/pages/che-7/hands-on-guidance/proc_choosing-the-sidecar-image.adoc
Outdated
Show resolved
Hide resolved
...es/che-7/hands-on-guidance/proc_verifying-the-vs-code-extension-api-compatibility-level.adoc
Outdated
Show resolved
Hide resolved
...es/che-7/hands-on-guidance/proc_verifying-the-vs-code-extension-api-compatibility-level.adoc
Outdated
Show resolved
Hide resolved
...es/che-7/hands-on-guidance/proc_verifying-the-vs-code-extension-api-compatibility-level.adoc
Outdated
Show resolved
Hide resolved
...es/che-7/hands-on-guidance/proc_verifying-the-vs-code-extension-api-compatibility-level.adoc
Outdated
Show resolved
Hide resolved
...hands-on-guidance/assembly_adding-che-plug-in-registry-vs-code-extension-to-a-workspace.adoc
Outdated
Show resolved
Hide resolved
Peer review has been done by @supriya-bharadwaj and @jherrmann.redhat.com |
d3ab9b2
to
b4f3c10
Compare
Signed-off-by: Michal Maléř <mmaler@redhat.com>
5c6c60f
to
01663e0
Compare
@MichalMaler I added your sign-off line and squashed the review commits. |
https://issues.jboss.org/browse/RHDEVDOCS-1153
adding content about Using a Visual Studio Code extension in Che -googledoc
rewrote this document into .adoc
https://docs.google.com/document/d/1gZHKXe1GEduY48RgntMUrqjSs9llq8WpCmgqssY5Ikw/edit#heading=h.s7tesxgcl8k3