-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installation guide - namespace per user strategy #825
Conversation
c48ef1d
to
9440649
Compare
src/main/pages/che-7/installation-guide/proc_configuring-namespace-strategies.adoc
Outdated
Show resolved
Hide resolved
src/main/pages/che-7/installation-guide/proc_configuring-namespace-strategies.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for the content to be published, the file will need to be included in the docs structure (see https://hackmd.io/c0nqIQK2Rki1u95h9h1X1Q). Please, let me know if you need help with that.
src/main/pages/che-7/installation-guide/proc_configuring-namespace-strategies.adoc
Outdated
Show resolved
Hide resolved
src/main/pages/che-7/installation-guide/proc_configuring-namespace-strategies.adoc
Outdated
Show resolved
Hide resolved
src/main/pages/che-7/installation-guide/proc_configuring-namespace-strategies.adoc
Outdated
Show resolved
Hide resolved
src/main/pages/che-7/installation-guide/proc_configuring-namespace-strategies.adoc
Outdated
Show resolved
Hide resolved
src/main/pages/che-7/installation-guide/proc_configuring-namespace-strategies.adoc
Outdated
Show resolved
Hide resolved
src/main/pages/che-7/installation-guide/proc_configuring-namespace-strategies.adoc
Outdated
Show resolved
Hide resolved
src/main/pages/che-7/installation-guide/proc_configuring-namespace-strategies.adoc
Outdated
Show resolved
Hide resolved
src/main/pages/che-7/installation-guide/proc_configuring-namespace-strategies.adoc
Outdated
Show resolved
Hide resolved
src/main/pages/che-7/installation-guide/proc_configuring-namespace-strategies.adoc
Outdated
Show resolved
Hide resolved
src/main/pages/che-7/installation-guide/proc_configuring-namespace-strategies.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Michal Vala <mvala@redhat.com> Co-Authored-By: Robert Krátký <rkratky@redhat.com>
34cfb18
to
86f9e27
Compare
I've fixed all comments and create new issue to document remaining strategies eclipse-che/che#14666. I can make the document public, but I would do that once all strategies are documented. WDYT @rkratky ? |
Signed-off-by: Michal Vala <mvala@redhat.com>
I've added page metadata header. Anything else needs to be done to publish the page @rkratky ? |
In the current state @sparkoo, if we merge the PR, it would publish https://www.eclipse.org/che/docs/che-7/configuring-namespace-strategies/ without making it visible in the menu (as the Installation Guide is currently disabled in the menu). Is it what you expect? Another question @sparkoo: would it make sense to have one procedure explaining how to to configure any namespace strategy + one reference explaining which namespace strategies are available? |
I'd like to ask you @themr0c if you think this page should be published in current state and how? Because my opinion is, that it does not make much sense without other strategies at least mentioned. I guess I'll have to write short paragraph about other strategies here to have this PR mergeable and page usable. Then we could publish it. |
…aces strategies Signed-off-by: Michal Vala <mvala@redhat.com>
It looks great @sparkoo. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As the installation guide is completely empty now, I am not sure we should enable it right now, or point the fact that this doc should be enabled when publishing the Installation Guide
Signed-off-by: Michal Vala mvala@redhat.com
What does this PR do?
document namespace strategy - namespace per user
What issues does this PR fix or reference?
eclipse-che/che#14624