Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make che-machine-exec track activity and stop workspace CR by idle timeout #106

Merged
merged 5 commits into from
May 27, 2020
Merged

Make che-machine-exec track activity and stop workspace CR by idle timeout #106

merged 5 commits into from
May 27, 2020

Conversation

sleshchenko
Copy link
Member

What does this PR do?

This PR makes che-machine-exec track activity and stop workspace CR by idle timeout.

Which issues does it solves?

It solves eclipse-che/che#16683

@sleshchenko sleshchenko self-assigned this May 26, 2020
@sleshchenko sleshchenko mentioned this pull request May 26, 2020
Merged
@sleshchenko sleshchenko marked this pull request as ready for review May 26, 2020 12:46
JPinkney
JPinkney approved these changes May 26, 2020
View reviewed changes
cfg/cfg.go Show resolved Hide resolved
activity/manager.go Show resolved Hide resolved
@sleshchenko
Make che-machine-exec track activity and stop workspace CR by idle ti…
9f7dd73 
…meout

Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
amisevsk
amisevsk reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The select seems to block workspace startup, since it waits for a signal but can't receive a signal until r.Run() is called.

activity/manager.go Show resolved Hide resolved
api/rest/activity.go Outdated Show resolved Hide resolved
activity/manager.go Outdated Show resolved Hide resolved
amisevsk and others added 2 commits May 26, 2020 13:02
@amisevsk
Move activity monitor into a goroutine
2d9bd69 
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@sleshchenko
Init channel when manager is created
cb26496 
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
@sleshchenko
Copy link
Member Author

sleshchenko commented May 26, 2020 •
edited
Loading

Now it seems to work as expected. Thank Angel for testing and finding critical bug!
I'm planning to try return pointer func to make sure that the activity manager is not run twice and even maybe move running go routing on manager.Start level, as it's done with server.Run().

@sleshchenko
Make ActivityManager#Start async
2540d1b 
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
@sleshchenko
Clean up unneeded debug logs
92d7e24 
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
@sleshchenko sleshchenko merged commit 0e49a3b into eclipse-che:master May 27, 2020
@sleshchenko sleshchenko deleted the activityChecking branch May 27, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisevsk amisevsk amisevsk left review comments

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@JPinkney JPinkney JPinkney approved these changes

@evidolob evidolob Awaiting requested review from evidolob

@l0rd l0rd Awaiting requested review from l0rd

@rhopp rhopp Awaiting requested review from rhopp

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

@sleshchenko sleshchenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sleshchenko @AndrienkoAleksandr @JPinkney @amisevsk