Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Align license headers validation. #193

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

AndrienkoAleksandr
Copy link
Contributor

Referenced issue:

eclipse-che/che#19946

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #193 (9de1ffb) into main (08830de) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   44.31%   44.31%           
=======================================
  Files          13       13           
  Lines         519      519           
=======================================
  Hits          230      230           
  Misses        286      286           
  Partials        3        3           
Impacted Files Coverage Δ
exec/activity-connection-saver.go 0.00% <ø> (ø)
exec/command_resolver.go 86.36% <ø> (ø)
exec/exec-manager-provider.go 0.00% <ø> (ø)
exec/health-watcher.go 100.00% <ø> (ø)
exec/kubernetes_exec_manager.go 0.00% <ø> (ø)
exec/namespace_provider.go 0.00% <ø> (ø)
exec/pty_handler.go 0.00% <ø> (ø)
filter/kubernetes_filter.go 58.69% <ø> (ø)
output/line-buffer/line_ringe_buffer.go 100.00% <ø> (ø)
output/line-buffer/line_scanner.go 100.00% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bea01...9de1ffb. Read the comment docs.

Copy link
Contributor

@tolusha tolusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Move license to hack folder
  2. Keep only one checker

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Copy link
Contributor Author

Move license to hack folder

done.

Keep only one checker

Ok, but I used initially one check.

@AndrienkoAleksandr AndrienkoAleksandr merged commit bd47a21 into main Nov 15, 2021
@AndrienkoAleksandr AndrienkoAleksandr deleted the alignLicenseHeaderValidation branch November 15, 2021 17:23
@che-bot che-bot added this to the 7.40 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants