Make che-machine-exec listen only on localhost by default #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metlos
requested review from
AndrienkoAleksandr,
evidolob,
rhopp and
vparfonov
as code owners
AndrienkoAleksandr
approved these changes
Feb 13, 2020
|
Let's just not merge this yet. Maybe it will be better solved by just changing the |
|
Closing this in favor of eclipse-che/che-plugin-registry#378. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse-che/che#15651 (and PR eclipse-che/che#15890) change the deployment of the JWT proxy in the che-server such that it is co-located in the workspace pod and the deployment of secure endpoints such that no services are created for them and the endpoints are assumed to be listening solely on
127.0.0.1.This makes the
che-machine-execconform to those assumptions and also makes it accessible ONLY through JWT proxy in the workspace.