Skip to content

Commit

Permalink
Support devWorkspace.ignoredUnrecoverableEvents.
Browse files Browse the repository at this point in the history
  • Loading branch information
@monaka
monaka committed Jun 27, 2024
1 parent 6cfe452 commit f820abd
Show file tree
Hide file tree
Showing 10 changed files with 93 additions and 1 deletion.
7 changes: 7 additions & 0 deletions api/v2/checluster_types.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,13 @@ type CheClusterDevEnvironments struct {
// +optional
// +kubebuilder:validation:Enum=Always;IfNotPresent;Never
ImagePullPolicy corev1.PullPolicy `json:"imagePullPolicy,omitempty"`
// IgnoredUnrecoverableEvents defines a list of Kubernetes event names that should
// be ignored when deciding to fail a DevWorkspace startup. This option should be used
// if a transient cluster issue is triggering false-positives (for example, if
// the cluster occasionally encounters FailedScheduling events). Events listed
// here will not trigger DevWorkspace failures.
// +optional
IgnoredUnrecoverableEvents []string `json:"ignoredUnrecoverableEvents,omitempty"`
}

// Che components configuration.
Expand Down
7 changes: 6 additions & 1 deletion api/v2/zz_generated.deepcopy.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions bundle/next/eclipse-che/manifests/org.eclipse.che_checlusters.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7010,6 +7010,16 @@ spec:
type: object
type: object
type: object
ignoredUnrecoverableEvents:
description: IgnoredUnrecoverableEvents defines a list of Kubernetes
event names that should be ignored when deciding to fail a
DevWorkspace startup. This option should be used if a transient
cluster issue is triggering false-positives (for example,
if the cluster occasionally encounters FailedScheduling events).
Events listed here will not trigger DevWorkspace failures.
items:
type: string
type: array
imagePullPolicy:
description: ImagePullPolicy defines the imagePullPolicy used
for containers in a DevWorkspace.
Expand Down
10 changes: 10 additions & 0 deletions config/crd/bases/org.eclipse.che_checlusters.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6963,6 +6963,16 @@ spec:
type: object
type: object
type: object
ignoredUnrecoverableEvents:
description: IgnoredUnrecoverableEvents defines a list of Kubernetes
event names that should be ignored when deciding to fail a DevWorkspace
startup. This option should be used if a transient cluster issue
is triggering false-positives (for example, if the cluster occasionally
encounters FailedScheduling events). Events listed here will
not trigger DevWorkspace failures.
items:
type: string
type: array
imagePullPolicy:
description: ImagePullPolicy defines the imagePullPolicy used
for containers in a DevWorkspace.
Expand Down
10 changes: 10 additions & 0 deletions deploy/deployment/kubernetes/combined.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6984,6 +6984,16 @@ spec:
type: object
type: object
type: object
ignoredUnrecoverableEvents:
description: IgnoredUnrecoverableEvents defines a list of Kubernetes
event names that should be ignored when deciding to fail a DevWorkspace
startup. This option should be used if a transient cluster issue
is triggering false-positives (for example, if the cluster occasionally
encounters FailedScheduling events). Events listed here will
not trigger DevWorkspace failures.
items:
type: string
type: array
imagePullPolicy:
description: ImagePullPolicy defines the imagePullPolicy used
for containers in a DevWorkspace.
Expand Down
10 changes: 10 additions & 0 deletions ...y/deployment/kubernetes/objects/checlusters.org.eclipse.che.CustomResourceDefinition.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6979,6 +6979,16 @@ spec:
type: object
type: object
type: object
ignoredUnrecoverableEvents:
description: IgnoredUnrecoverableEvents defines a list of Kubernetes
event names that should be ignored when deciding to fail a DevWorkspace
startup. This option should be used if a transient cluster issue
is triggering false-positives (for example, if the cluster occasionally
encounters FailedScheduling events). Events listed here will
not trigger DevWorkspace failures.
items:
type: string
type: array
imagePullPolicy:
description: ImagePullPolicy defines the imagePullPolicy used
for containers in a DevWorkspace.
Expand Down
10 changes: 10 additions & 0 deletions deploy/deployment/openshift/combined.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6984,6 +6984,16 @@ spec:
type: object
type: object
type: object
ignoredUnrecoverableEvents:
description: IgnoredUnrecoverableEvents defines a list of Kubernetes
event names that should be ignored when deciding to fail a DevWorkspace
startup. This option should be used if a transient cluster issue
is triggering false-positives (for example, if the cluster occasionally
encounters FailedScheduling events). Events listed here will
not trigger DevWorkspace failures.
items:
type: string
type: array
imagePullPolicy:
description: ImagePullPolicy defines the imagePullPolicy used
for containers in a DevWorkspace.
Expand Down
10 changes: 10 additions & 0 deletions ...oy/deployment/openshift/objects/checlusters.org.eclipse.che.CustomResourceDefinition.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6979,6 +6979,16 @@ spec:
type: object
type: object
type: object
ignoredUnrecoverableEvents:
description: IgnoredUnrecoverableEvents defines a list of Kubernetes
event names that should be ignored when deciding to fail a DevWorkspace
startup. This option should be used if a transient cluster issue
is triggering false-positives (for example, if the cluster occasionally
encounters FailedScheduling events). Events listed here will
not trigger DevWorkspace failures.
items:
type: string
type: array
imagePullPolicy:
description: ImagePullPolicy defines the imagePullPolicy used
for containers in a DevWorkspace.
Expand Down
10 changes: 10 additions & 0 deletions helmcharts/next/crds/checlusters.org.eclipse.che.CustomResourceDefinition.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6979,6 +6979,16 @@ spec:
type: object
type: object
type: object
ignoredUnrecoverableEvents:
description: IgnoredUnrecoverableEvents defines a list of Kubernetes
event names that should be ignored when deciding to fail a DevWorkspace
startup. This option should be used if a transient cluster issue
is triggering false-positives (for example, if the cluster occasionally
encounters FailedScheduling events). Events listed here will
not trigger DevWorkspace failures.
items:
type: string
type: array
imagePullPolicy:
description: ImagePullPolicy defines the imagePullPolicy used
for containers in a DevWorkspace.
Expand Down
10 changes: 10 additions & 0 deletions pkg/deploy/dev-workspace-config/dev_workspace_config.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ func updateWorkspaceConfig(ctx *chetypes.DeployContext, operatorConfig *controll

updateWorkspaceImagePullPolicy(devEnvironments.ImagePullPolicy, operatorConfig.Workspace)

updateIgnoredUnrecoverableEvents(operatorConfig, devEnvironments.IgnoredUnrecoverableEvents)

// If the CheCluster has a configured proxy, or if the Che Operator has detected a proxy configuration,
// we need to disable automatic proxy handling in the DevWorkspace Operator as its implementation collides
// with ours -- they set environment variables the deployment spec explicitly, which overrides the proxy-settings
Expand Down Expand Up @@ -194,6 +196,14 @@ func updateWorkspaceImagePullPolicy(imagePullPolicy corev1.PullPolicy, workspace
workspaceConfig.ImagePullPolicy = string(imagePullPolicy)
}

func updateIgnoredUnrecoverableEvents(operatorConfig *controllerv1alpha1.OperatorConfiguration, ignoredUnrecoverableEvents []string) {
if ignoredUnrecoverableEvents == nil {
operatorConfig.Workspace.IgnoredUnrecoverableEvents = nil
} else {
operatorConfig.Workspace.IgnoredUnrecoverableEvents = ignoredUnrecoverableEvents
}
}

func updateWorkspaceServiceAccountConfig(devEnvironments *chev2.CheClusterDevEnvironments, workspaceConfig *controllerv1alpha1.WorkspaceConfig) {
isNamespaceAutoProvisioned := pointer.BoolDeref(devEnvironments.DefaultNamespace.AutoProvision, constants.DefaultAutoProvision)

Expand Down

0 comments on commit f820abd

Please sign in to comment.