-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: configure runtime controller with namespace event filter #1146
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
/retest |
config/manager/manager.yaml
Outdated
requests: | ||
cpu: 100m | ||
memory: 64Mi | ||
memory: 256Mi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need to increase request memory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. We can keep old value.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, mmorhun, sparkoo, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
New changes are detected. LGTM label has been removed. |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Red Hat Jira for CRW release notes: https://issues.redhat.com/browse/CRW-2595 |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Configure runtime controller with namespace event filter to limit cache.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-2383
How to test this PR?
for i in {1..500}; do oc create namespace test$i; done
When operator deployment is created then patch it increase limits
oc patch deployment/che-operator -p '[{"op": "replace", "path": "/spec/template/spec/containers/0/resources/limits/memory", "value":"512Mi"}]' --type=json -n eclipse-che
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Release Notes Text
Title: Fix out of memory Che Operator error when the Kubernetes cluster has many namespaces
The latest version of Che Operator crashed with an OOM error in cluster with many namesapeces because it caches more than just the local namespace's objects. The workaround is to increase the memory limit.