Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configure runtime controller with namespace event filter #1146

Merged
merged 4 commits into from
Oct 18, 2021
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Oct 17, 2021

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Configure runtime controller with namespace event filter to limit cache.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-2383

How to test this PR?

  1. Create namespaces for i in {1..500}; do oc create namespace test$i; done
  2. Deploy Eclipse Che
chectl server:deploy \
     --installer operator \
     --platform openshift \
     --che-operator-image abazko/operator:crw-2383

When operator deployment is created then patch it increase limits
oc patch deployment/che-operator -p '[{"op": "replace", "path": "/spec/template/spec/containers/0/resources/limits/memory", "value":"512Mi"}]' --type=json -n eclipse-che

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Release Notes Text

Title: Fix out of memory Che Operator error when the Kubernetes cluster has many namespaces

The latest version of Che Operator crashed with an OOM error in cluster with many namesapeces because it caches more than just the local namespace's objects. The workaround is to increase the memory limit.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Oct 18, 2021

/retest

requests:
cpu: 100m
memory: 64Mi
memory: 256Mi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need to increase request memory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. We can keep old value.

@mmorhun mmorhun removed their assignment Oct 18, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, sparkoo, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Oct 18, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2021

New changes are detected. LGTM label has been removed.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2021

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v7-devworkspace-happy-path 3d31a84 link true /test v7-devworkspace-happy-path
ci/prow/v7-single-host-nightly-deployment 3d31a84 link true /test v7-single-host-nightly-deployment

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha merged commit 06aa35c into main Oct 18, 2021
@tolusha tolusha deleted the CRW-2383 branch October 18, 2021 10:53
@che-bot che-bot added this to the 7.38 milestone Oct 18, 2021
@l0rd l0rd added new&noteworthy status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Oct 19, 2021
@themr0c
Copy link

themr0c commented Dec 22, 2021

Red Hat Jira for CRW release notes: https://issues.redhat.com/browse/CRW-2595

@themr0c themr0c added status/release-notes-review-done Issues that have been reviewed by the doc team for the Release Notes wording and removed status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new&noteworthy status/release-notes-review-done Issues that have been reviewed by the doc team for the Release Notes wording
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants