Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set CHE_INFRA_KUBERNETES_ENABLE__UNSUPPORTED__K8S: true when dev… #1155

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Oct 21, 2021

…workspace is enabled on k8s

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Set CHE_INFRA_KUBERNETES_ENABLE__UNSUPPORTED__K8S: true when devworkspace is enabled on k8s

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#20620

How to test this PR?

chectl server:deploy \
     --installer operator \
     --workspace-engine=dev-workspace \
     --platform minikube \
     --che-operator-image abazko/operator:20620

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…workspace is enabled on k8s

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2021

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v7-devworkspace-happy-path 7900671 link true /test v7-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha
Copy link
Contributor Author

tolusha commented Oct 21, 2021

/retest

@openshift-ci openshift-ci bot added the lgtm label Oct 21, 2021
@mmorhun mmorhun assigned tolusha and unassigned mmorhun Oct 21, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit a889b56 into main Oct 21, 2021
@tolusha tolusha deleted the 20620 branch October 21, 2021 12:33
@che-bot che-bot added this to the 7.39 milestone Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants