Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix OLM dev commands. #1161

Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix: Fix OLM dev commands. #1161

merged 1 commit into from
Nov 2, 2021

Conversation

AndrienkoAleksandr
Copy link
Contributor

What does this PR do?

Fix OLM dev commands.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

None. Fix dev flow.

How to test this PR?

cat EOF << > /tmp/patch.yaml
<PATCH_CONTENT>
EOF

chectl server:deploy \
     --installer operator \
     --platform <PLATFORM_TO_DEPLOY> \
     --che-operator-image <CUSTOM_OPERATOR_IMAGE> \
     --che-operator-cr-patch-yaml /tmp/patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Nov 1, 2021

@AndrienkoAleksandr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v7-multi-host-next-deployment b4b00ba link true /test v7-multi-host-next-deployment
ci/prow/v7-stable-to-nightly b4b00ba link true /test v7-stable-to-nightly

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -12,6 +12,6 @@ configMapGenerator:
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
images:
- name: controller
- name: quay.io/eclipse/che-operator:next
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm Does it really need?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's how this kustomize feature works.

@tolusha
Copy link
Contributor

tolusha commented Nov 2, 2021

/retest

@tolusha tolusha mentioned this pull request Nov 2, 2021
25 tasks
@tolusha tolusha merged commit 78673e1 into main Nov 2, 2021
@tolusha tolusha deleted the fixOLMDevCommands branch November 2, 2021 08:22
@openshift-ci
Copy link

openshift-ci bot commented Nov 2, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@che-bot che-bot added this to the 7.39 milestone Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants