Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix license headers #1170

Merged
merged 18 commits into from
Nov 16, 2021
Merged

fix: Fix license headers #1170

merged 18 commits into from
Nov 16, 2021

Conversation

AndrienkoAleksandr
Copy link
Contributor

What does this PR do?

fix: Fix license headers

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#19946

How to test this PR?

cat EOF << > /tmp/patch.yaml
<PATCH_CONTENT>
EOF

chectl server:deploy \
     --installer operator \
     --platform <PLATFORM_TO_DEPLOY> \
     --che-operator-image <CUSTOM_OPERATOR_IMAGE> \
     --che-operator-cr-patch-yaml /tmp/patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #1170 (49f6105) into main (9721a3b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1170   +/-   ##
=======================================
  Coverage   57.45%   57.45%           
=======================================
  Files          76       76           
  Lines        8642     8642           
=======================================
  Hits         4965     4965           
  Misses       3139     3139           
  Partials      538      538           
Impacted Files Coverage Δ
api/conversion.go 84.93% <ø> (ø)
controllers/che/backup.go 23.80% <ø> (ø)
controllers/che/checluster_controller.go 24.34% <ø> (ø)
controllers/che/checluster_validator.go 0.00% <ø> (ø)
controllers/che/cheobj_verifier.go 67.56% <ø> (ø)
controllers/che/configmap_cert.go 81.25% <ø> (ø)
controllers/che/create.go 44.80% <ø> (ø)
controllers/che/gateway_permission.go 62.16% <ø> (ø)
controllers/che/permission_checker.go 0.00% <ø> (ø)
controllers/che/proxy.go 61.11% <ø> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9721a3b...49f6105. Read the comment docs.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Copy link
Contributor

@tolusha tolusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check release scripts

@openshift-ci
Copy link

openshift-ci bot commented Nov 15, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -1,6 +1,6 @@
#!/bin/bash
#
# Copyright (c) 2020 Red Hat, Inc.
# Copyright (c) 2019-2021 Red Hat, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We lose original creation date

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I thought we considered in the stand up to align all license headers to the same value, but after that developers should care about correct year for new files.

@@ -1,12 +1,15 @@
#!/bin/bash
#
# Copyright (c) 2012-2021 Red Hat, Inc.
# Copyright (c) 2019-2021 Red Hat, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same here

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Nov 15, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Nov 15, 2021
@AndrienkoAleksandr
Copy link
Contributor Author

/test v8-single-host-next-deployment

@AndrienkoAleksandr AndrienkoAleksandr merged commit b4930b5 into main Nov 16, 2021
@AndrienkoAleksandr AndrienkoAleksandr deleted the fixLicenseHeaders branch November 16, 2021 09:17
@che-bot che-bot added this to the 7.40 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants