Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delegate permissions to get, list, watch pods/log resources #1212

Merged
merged 4 commits into from
Dec 6, 2021
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Dec 2, 2021

@tolusha tolusha changed the title fix: delete 'edit' cluster role to 'che' service account fix: delegate 'edit' cluster role to 'che' service account Dec 2, 2021
@tolusha tolusha mentioned this pull request Dec 2, 2021
28 tasks
@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Dec 3, 2021
@tolusha tolusha changed the title fix: delegate 'edit' cluster role to 'che' service account fix: delegate roles on 'pods/log' resource Dec 6, 2021
@tolusha
Copy link
Contributor Author

tolusha commented Dec 6, 2021

/retest

@tolusha tolusha changed the title fix: delegate roles on 'pods/log' resource fix: delegate permissions to get, list, watch 'pods/log' resources Dec 6, 2021
@tolusha tolusha changed the title fix: delegate permissions to get, list, watch 'pods/log' resources fix: delegate permissions to get, list, watch pods/log resources Dec 6, 2021
@mmorhun mmorhun assigned tolusha and unassigned mmorhun Dec 6, 2021
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Dec 6, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha
Copy link
Contributor Author

tolusha commented Dec 6, 2021

Terminal works fine

@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2021

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v7-stable-to-nightly 3276623 link true /test v7-stable-to-nightly
ci/prow/v7-devworkspace-happy-path 3276623 link true /test v7-devworkspace-happy-path
ci/prow/v7-single-host-nightly-deployment 3276623 link true /test v7-single-host-nightly-deployment
ci/prow/v7-multi-host-next-deployment 3276623 link true /test v7-multi-host-next-deployment
ci/prow/v9-stable-to-nightly 2932093 link true /test v9-stable-to-nightly
ci/prow/v9-devworkspace-happy-path 2932093 link true /test v9-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha merged commit b4511e3 into main Dec 6, 2021
@tolusha tolusha deleted the 20681 branch December 6, 2021 13:25
@che-bot che-bot added this to the 7.41 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants