Drop databases before restore #1227
Conversation
mmorhun
requested review from
AndrienkoAleksandr,
flacatus,
nickboldt and
tolusha
as code owners
| for _, dbName := range databasesToDrop { | ||
| execReason := fmt.Sprintf("dropping %s database", dbName) | ||
| dropDatabaseCommand := fmt.Sprintf("psql -c \"DROP DATABASE %s;\"", dbName) | ||
| if output, err := k8sClient.DoExecIntoPod(rctx.namespace, postgresPodName, dropDatabaseCommand, execReason); err != nil { |
There was a problem hiding this comment.
What about returning `err ?
There was a problem hiding this comment.
I think, we shouldn't break the process. This step is only needed when database format is changed.
mmorhun
force-pushed
the
che-20812
branch
2 times, most recently
from
7506977
to
dc632d5
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
@mmorhun: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do?
Drop databases before restore in order to be able to deploy clean Che in case of incompatible Postgres data formats.
Do not migrate objects related to backup.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#20812
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.