fix: check if tag exists on remote before... #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ibf0021ef56d5d1f18fc9e1181ea6029b6a694738 Signed-off-by: nickboldt <nboldt@redhat.com>
nickboldt
requested review from
AndrienkoAleksandr,
flacatus,
mmorhun and
tolusha
as code owners
mkuznyetsov
reviewed
Dec 6, 2021
make-release.sh
Outdated
| git tag -d $RELEASE | ||
| if [[ $(git ls-remote --tags $(git remote get-url origin) $RELEASE) ]]; then # if tag exists in remote repo | ||
| echo "Remove existing tag $RELEASE" | ||
| git tag -d $RELEASE || true |
There was a problem hiding this comment.
instead of || true, maybe use a separate if block with $(git tag -l | grep $RELEASE)?
nickboldt
force-pushed
the
better-check-if-tag-exists
branch
from
8c58d9e to
3b1a27f
Compare
Change-Id: I632914e164fd122e2cbede4650fc919fc1b7c6fc Signed-off-by: nickboldt <nboldt@redhat.com> remove or-true Change-Id: I292eeb5787d2174a0f158895755194fbc837fef2 Signed-off-by: nickboldt <nboldt@redhat.com> don't grep, just use explicit pattern (avoid 7.40.0-release) Change-Id: Ied835ac42c5f15ca8a138eda6eb56a51badb382a Signed-off-by: nickboldt <nboldt@redhat.com>
nickboldt
force-pushed
the
better-check-if-tag-exists
branch
from
3b1a27f to
f372f08
Compare
mkuznyetsov
approved these changes
Dec 6, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkuznyetsov, nickboldt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix: check if tag exists on remote before attempting to delete it
Change-Id: Ibf0021ef56d5d1f18fc9e1181ea6029b6a694738
Signed-off-by: nickboldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Fix for https://github.com/eclipse-che/che-operator/runs/4430414080?check_suite_focus=true
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.