Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add extra labels to CRDS files. #1232

Merged
merged 1 commit into from
Dec 8, 2021
Merged

feat: Add extra labels to CRDS files. #1232

merged 1 commit into from
Dec 8, 2021

Conversation

AndrienkoAleksandr
Copy link
Contributor

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

What does this PR do?

feat: Add extra labels to CRDS files.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Fill missed part.

How to test this PR?

cat EOF << > /tmp/patch.yaml
<PATCH_CONTENT>
EOF

chectl server:deploy \
     --installer operator \
     --platform <PLATFORM_TO_DEPLOY> \
     --che-operator-image <CUSTOM_OPERATOR_IMAGE> \
     --che-operator-cr-patch-yaml /tmp/patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@tolusha
Copy link
Contributor

tolusha commented Dec 7, 2021

cc
@ArvinB

@tolusha tolusha mentioned this pull request Dec 7, 2021
28 tasks
@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun mmorhun assigned AndrienkoAleksandr and unassigned tolusha and mmorhun Dec 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2021

@AndrienkoAleksandr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v9-devworkspace-happy-path 0f1ca1a link true /test v9-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ArvinB
Copy link
Contributor

ArvinB commented Dec 7, 2021

@tolusha Huge Thank you!

@ArvinB
Copy link
Contributor

ArvinB commented Dec 7, 2021

@nickboldt FYI

@tolusha tolusha merged commit 9700014 into main Dec 8, 2021
@tolusha tolusha deleted the extra_labels_in_crds branch December 8, 2021 07:08
@che-bot che-bot added this to the 7.41 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants