chore: Refactoring #1236
chore: Refactoring #1236
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
tolusha
requested review from
AndrienkoAleksandr,
flacatus,
mmorhun and
nickboldt
as code owners
|
/retest |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
| reconcileManager.RegisterReconciler(dashboard.NewDashboardReconciler()) | ||
| reconcileManager.RegisterReconciler(gateway.NewGatewayReconciler()) | ||
| reconcileManager.RegisterReconciler(server.NewCheServerReconciler()) | ||
| reconcileManager.RegisterReconciler(consolelink.NewConsoleLinkReconciler()) |
There was a problem hiding this comment.
Minor: Maybe, we can check here if Openshift 4, then register reconsiler.
|
@tolusha: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| func (p *DefaultValuesReconciler) Reconcile(ctx *deploy.DeployContext) (reconcile.Result, bool, error) { | ||
| cheFlavor := deploy.DefaultCheFlavor(ctx.CheCluster) | ||
| cheNamespace := ctx.CheCluster.Namespace | ||
| if len(ctx.CheCluster.Spec.Server.CheFlavor) < 1 { |
There was a problem hiding this comment.
Up to you, but for me looks better len(ctx.CheCluster.Spec.Server.CheFlavor) == 0
| ctx.CheCluster.Spec.Server.CustomCheProperties[k] = v | ||
| } | ||
|
|
||
| err := ctx.ClusterAPI.Client.Update(context.TODO(), ctx.CheCluster) |
There was a problem hiding this comment.
Maybe we can use deploy.UpdateCheCRSpec here.
What does this PR do?
Refactoring
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#19284
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.