Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch to DevWorkspace engine by default #1265

Merged
merged 11 commits into from
Dec 24, 2021
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Dec 20, 2021

What does this PR do?

Switching to DevWorkspace engine by default:

  • removes tech-preview channels
  • set devworkspace.enable: true by default
  • adopt tests scripts

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#20866

How to test this PR?

See PR checks

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha
Copy link
Contributor Author

tolusha commented Dec 22, 2021

/retest

1 similar comment
@tolusha
Copy link
Contributor Author

tolusha commented Dec 22, 2021

/retest

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Dec 23, 2021

/test v8-che-behind-proxy

1 similar comment
@tolusha
Copy link
Contributor Author

tolusha commented Dec 23, 2021

/test v8-che-behind-proxy

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #1265 (bc6e069) into main (93729ca) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1265      +/-   ##
==========================================
- Coverage   56.83%   56.77%   -0.06%     
==========================================
  Files          84       84              
  Lines        8729     8720       -9     
==========================================
- Hits         4961     4951      -10     
- Misses       3271     3273       +2     
+ Partials      497      496       -1     
Impacted Files Coverage Δ
pkg/deploy/defaults.go 47.59% <ø> (+0.45%) ⬆️
pkg/deploy/dev-workspace/dev_workspace.go 55.55% <ø> (-1.83%) ⬇️
pkg/deploy/dev-workspace/dev_workspace_utils.go 71.15% <0.00%> (-9.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93729ca...bc6e069. Read the comment docs.

@openshift-ci
Copy link

openshift-ci bot commented Dec 24, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Dec 24, 2021
@tolusha tolusha merged commit 100e6a4 into main Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants