-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support node selector and pod tolerations in devworkspaces #1301
feat: Support node selector and pod tolerations in devworkspaces #1301
Conversation
* Upgrade to devworkspace operator with support for pod tolerations * Implement additional logic in usernamespace controller to sync config from checluster CR to ns annotations understood by the dwo * Add new fields to CheCluster CRD v1 and v2alpha1 * added support for the new fields in conversion methods between v1 and v2alpha1
reverted dwo update
user namespace reconciliation.
/retest |
@tolusha, help please! How do I unblock the two stuck jobs? |
/retest |
I don't know. We can wait or close/opene the PR (I hope it will work) |
/retest |
1 similar comment
/retest |
Codecov Report
@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
+ Coverage 60.35% 60.43% +0.08%
==========================================
Files 77 77
Lines 6275 6337 +62
==========================================
+ Hits 3787 3830 +43
- Misses 2112 2121 +9
- Partials 376 386 +10
Continue to review full report at Codecov.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: metlos, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
What does this PR do?
This adds support for a couple of things:
the
CheCluster
CRD v1 underspec.server.workspacePodTolerations
andspec.server.workspacePodNodeSelector
in addition to the
CHE_WORKSPACE_POD_NODE__SELECTOR
andCHE_WORKSPACE_POD_TOLERATIONS__JSON
customproperties,
spec.workspaces.podTolerations
andspec.workspaces.podNodeSelector
,the properties, or if not found there, from the custom che properties)
the devworkspace operator to apply the node selector and pod toleration configuration to the actual
devworkspace pods.
Screenshot/screencast of this PR
none
What issues does this PR fix or reference?
eclipse-che/che#20884
How to test this PR?
quay.io/lkrejci/che-operator:issue-20884
)PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.