Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable HTTP2 protocol #1315

Merged
merged 1 commit into from
Feb 3, 2022
Merged

fix: Disable HTTP2 protocol #1315

merged 1 commit into from
Feb 3, 2022

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Feb 3, 2022

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Disable HTTP2 protocol

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-2677

How to test this PR?

  1. Create eclipse-che namespace
  2. Create 2 configmaps with the following lables:
  labels:
    app.kubernetes.io/component: ca-bundle
    app.kubernetes.io/instance: codeready
    app.kubernetes.io/part-of: che.eclipse.org
    config.openshift.io/inject-trusted-cabundle: 'true'
  1. Deploy Eclipse Che with che-server engine
  2. Create a workspace

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v9-che-operator-update aa0ac95 link true /test v9-che-operator-update
ci/prow/v8-che-operator-update aa0ac95 link true /test v8-che-operator-update

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skabashnyuk, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 43ae9ab into 7.42.x Feb 3, 2022
@tolusha tolusha deleted the crw2677 branch February 3, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants