Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable HTTP2 protocol #1319

Merged
merged 1 commit into from
Feb 4, 2022
Merged

fix: Disable HTTP2 protocol #1319

merged 1 commit into from
Feb 4, 2022

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Feb 4, 2022

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

fix: Disable HTTP2 protocol

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-2677

How to test this PR?

  1. Create eclipse-che namespace
  2. Create 2 configmaps with the following lables:
  labels:
    app.kubernetes.io/component: ca-bundle
    app.kubernetes.io/instance: codeready
    app.kubernetes.io/part-of: che.eclipse.org
    config.openshift.io/inject-trusted-cabundle: 'true'
  1. Deploy Eclipse Che with che-server engine
  2. Create a workspac

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Feb 4, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha mentioned this pull request Feb 4, 2022
18 tasks
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #1319 (15e3e0d) into main (a00fe51) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1319   +/-   ##
=======================================
  Coverage   60.52%   60.53%           
=======================================
  Files          77       77           
  Lines        6354     6355    +1     
=======================================
+ Hits         3846     3847    +1     
  Misses       2122     2122           
  Partials      386      386           
Impacted Files Coverage Δ
pkg/deploy/server/server_configmap.go 85.62% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00fe51...15e3e0d. Read the comment docs.

@tolusha tolusha merged commit 56ba949 into main Feb 4, 2022
@tolusha tolusha deleted the crw2677_main branch February 4, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant