Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new fields in CheCluster CR to configure Git Services #1457

Merged
merged 10 commits into from
Sep 8, 2022
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jul 26, 2022

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

  • Add new fields in CheCluster CR to configure Git Services.
  • Automatically sets the required labels and annotations to Git integration secrets

Screenshot/screencast of this PR

screenshot-console-openshift-console apps ci-ln-zr383rt-72292 origin-ci-int-gce dev rhcloud com-2022 09 07-13_46_10
screenshot-console-openshift-console apps ci-ln-zr383rt-72292 origin-ci-int-gce dev rhcloud com-2022 09 07-13_45_59
screenshot-console-openshift-console apps ci-ln-zr383rt-72292 origin-ci-int-gce dev rhcloud com-2022 09 07-13_45_43

What issues does this PR fix or reference?

eclipse-che/che#21577

How to test this PR?

Catalog source image to test: docker.io/abazko/catalog:21577

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha
Copy link
Contributor Author

tolusha commented Jul 27, 2022

/retest

@tolusha
Copy link
Contributor Author

tolusha commented Jul 29, 2022

@l0rd
Could you have a look pls?

Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tolusha good work. I have added a few suggestions.

api/v2/checluster_types.go Outdated Show resolved Hide resolved
api/v2/checluster_types.go Outdated Show resolved Hide resolved
api/v2/checluster_types.go Outdated Show resolved Hide resolved
api/v2/checluster_types.go Show resolved Hide resolved
api/v2/checluster_types.go Show resolved Hide resolved
api/v2/checluster_types.go Outdated Show resolved Hide resolved
api/v2/checluster_types.go Outdated Show resolved Hide resolved
api/v2/checluster_types.go Outdated Show resolved Hide resolved
api/v2/checluster_types.go Outdated Show resolved Hide resolved
api/v2/checluster_types.go Outdated Show resolved Hide resolved
@tolusha
Copy link
Contributor Author

tolusha commented Aug 6, 2022

This PR has to be updated to mention Bitbucket SAAS OAuth flow
Depends on eclipse-che/che-docs#2410

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Sep 7, 2022

/test v11-upgrade-stable-to-next

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2022

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v10-che-behind-proxy 8e073f6 link true /test v10-che-behind-proxy
ci/prow/v9-operator-test 8e073f6 link true /test v9-operator-test
ci/prow/v9-devworkspace-happy-path 8e073f6 link true /test v9-devworkspace-happy-path
ci/prow/v11-devworkspace-happy-path 36c01ec link true /test v11-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha merged commit bbec586 into main Sep 8, 2022
@tolusha tolusha deleted the 21577 branch September 8, 2022 13:53
@che-bot che-bot added this to the 7.54 milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants