-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow to set environment variables into Eclipse Che containers #1468
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Codecov Report
@@ Coverage Diff @@
## main #1468 +/- ##
==========================================
- Coverage 60.36% 60.33% -0.04%
==========================================
Files 74 74
Lines 6275 6287 +12
==========================================
+ Hits 3788 3793 +5
- Misses 2119 2126 +7
Partials 368 368
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tolusha, I commented minor change, but in overall this PR is great!
pkg/common/utils/utils.go
Outdated
@@ -102,6 +102,16 @@ func GetEnv(envs []corev1.EnvVar, name string) string { | |||
return "" | |||
} | |||
|
|||
func FindEnv(envs []corev1.EnvVar, name string) int { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor remark: can we rename this method just to be more specific? For example:
// Index returns the index of the first element of envs with requested name, or -1 if envs has no such element.
func Index(envs []corev1.EnvVar, name string) int {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karatkep
Sure
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Allow to set environment variables into Eclipse Che containers
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#21605
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.