feat: configure DWOC from che-operator CR

[AObuchow]

What does this PR do?

This PR adds a new reconciler which is in charge of creating and updating a DevWorkspace-Operator configuration (DWOC) in the che cluster namespace.
The intention is to propagate relevant fields from the che cluster custom resource to the DWOC.

Currently, only the following (storage related) fields are propagated from the che cluster custom resource to the DWOC:

• checluster.spec.devEnvironments.Storage.pvcStrategy
• checluster.spec.devEnvironments.Storage.perUserStrategyPvcConfig.ClaimSize
• checluster.spec.devEnvironments.Storage.perUserStrategyPvcConfig.StorageClass
• checluster.spec.devEnvironments.Storage.perWorkspaceStrategyPvcConfig.ClaimSize
• checluster.spec.devEnvironments.Storage.perWorkspaceStrategyPvcConfig.StorageClass

The DWOC fields which can receive values from the che cluster are:

• workspace.storageClassName
• workspace.defaultStorageSize.common
• workspace.defaultStorageSize.perWorkspace

Screenshot/screencast of this PR

n/a

What issues does this PR fix or reference?

Part of eclipse-che/che/issues/21405

How to test this PR?

There are a few automated tests that were added.

For manual testing (on minikube):

1. Build and push the che-operator image to quay
2. Deploy che using the custom che-operator image: chectl server:deploy --installer operator -p minikube --che-operator-image=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-operator:next
3. Once deployed, check to ensure the che-owned DWOC has been created:

[aobuchow@fedora ~]$ kubectl describe devworkspaceoperatorconfigs.controller.devfile.io -n eclipse-che
Name:         devworkspace-config
Namespace:    eclipse-che
Labels:       <none>
Annotations:  <none>
API Version:  controller.devfile.io/v1alpha1
Config:
Kind:                    DevWorkspaceOperatorConfig
Metadata:
...

4. Edit the che cluster's storage-related fields so that they can be propagated to the DWOC: kubectl edit checluster eclipse-che -n eclipse-che

...
  devEnvironments:
    defaultComponents:
    - container:
        image: quay.io/devfile/universal-developer-image:ubi8-38da5c2
        sourceMapping: /projects
      name: universal-developer-image
    defaultEditor: eclipse/che-theia/latest
    defaultNamespace:
      template: <username>-che
    secondsOfInactivityBeforeIdling: 1800
    secondsOfRunBeforeIdling: -1
    storage:
+     perUserStrategyPvcConfig:
+       claimSize: 15Gi
+       storageClass: testName
      pvcStrategy: per-user

5. Ensure the appropriate changes have been made to the DWOC. In this example, the common storage size should be set to 15Gi and the storage class name should be set to testName.

[aobuchow@fedora ~]$ kubectl describe devworkspaceoperatorconfigs.controller.devfile.io -n eclipse-che
Name:         devworkspace-config
Namespace:    eclipse-che
Labels:       <none>
Annotations:  <none>
API Version:  controller.devfile.io/v1alpha1
Config:
  Workspace:
+   Default Storage Size:
+     Common:            15Gi
+   Storage Class Name:  testName
Kind:                    DevWorkspaceOperatorConfig
Metadata:

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• Custom resource definition file is up to date](https://github.com/eclipse-che/che-operator/blob/main/README.md#updating-custom-resource-definition-file)
• OLM bundles are up to date
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[openshift-ci]

Hi @AObuchow. Thanks for your PR.

I'm waiting for a eclipse-che member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #1494 (b95e81c) into main (aa27398) will increase coverage by 0.24%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##             main    #1494      +/-   ##
==========================================
+ Coverage   60.26%   60.51%   +0.24%     
==========================================
  Files          76       77       +1     
  Lines        6262     6308      +46     
==========================================
+ Hits         3774     3817      +43     
- Misses       2125     2128       +3     
  Partials      363      363              

Impacted Files	Coverage Δ
controllers/che/checluster_controller.go	0.00% <0.00%> (ø)
pkg/deploy/server/server_configmap.go	71.05% <ø> (+0.79%)	⬆️
...eploy/dev-workspace-config/dev_workspace_config.go	90.19% <90.19%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AObuchow, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[AObuchow]

@tolusha thank you so much for the refactor, things are looking much cleaner now.

The only issue I've found is that, since the pvc.claimSize is a string in the CRD (and not a resource.Quantity), it's possible for resource.MustParse(pvc.ClaimSize) to fail and cause a panic. resource.ParseQuantity() should be used instead.

Want me to submit a fixup for this?

[AObuchow]

I submitted the fix up. In the process I had rebased the branch which accidentally dragged some extra commits onto this PR, sorry about that. I can remove those from the PR if desired.

[tolusha]

Everything looks fine. Merge if needed.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[tolusha]

/retest

[AObuchow]

@tolusha I squashed the fix up commit, should be good for merge whenever the tests complete.

[tolusha]

Do we need backport to 7.52.x?

[AObuchow]

Do we need backport to 7.52.x?

Yes 👍

[openshift-ci]

@AObuchow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v11-devworkspace-happy-path	b95e81c	link	true	/test v11-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tolusha]

Backported 0a3d57c

[AObuchow]

@tolusha Thank you for all the help :)