Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable readiness probe in case of debug Eclipse Che Server #160

Merged
merged 3 commits into from
Feb 4, 2020

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jan 30, 2020

Signed-off-by: Anatoliy Bazko abazko@redhat.com

Reference issue

eclipse-che/che#14976

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one inline comment

pkg/deploy/deployment_che.go Outdated Show resolved Hide resolved
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Copy link
Contributor

@davidfestal davidfestal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but with one comment and suggested change.

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha tolusha merged commit 5039e1f into master Feb 4, 2020
@tolusha tolusha deleted the ab/disableprobeindebug branch February 4, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants