-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove PostgreSQL component #1630
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1630 +/- ##
==========================================
- Coverage 58.33% 58.10% -0.24%
==========================================
Files 73 70 -3
Lines 8530 8177 -353
==========================================
- Hits 4976 4751 -225
+ Misses 3219 3106 -113
+ Partials 335 320 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/retest |
api/v2/checluster_types.go
Outdated
@@ -302,6 +302,7 @@ type DevfileRegistry struct { | |||
ExternalDevfileRegistries []ExternalDevfileRegistry `json:"externalDevfileRegistries,omitempty"` | |||
} | |||
|
|||
// Database component is Deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should add a note that not only it is deprecated but that all the properties set on CR level will be ignored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
che-operator/api/v2/checluster_types.go
Line 163 in 6d55913
// Database component is Deprecated. All properties will be ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great cleanup job 👍
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
/retest |
Build 3.6 :: operator_3.x/198: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2563: Console, Changes, Git Data |
Build 3.6 :: operator-bundle_3.x/968: Console, Changes, Git Data |
Build 3.6 :: push-latest-container-to-quay_3.x/1849: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2564: Console, Changes, Git Data |
Build 3.6 :: operator-bundle_3.x/969: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2566: Console, Changes, Git Data |
Build 3.6 :: update-digests_3.x/2347: Console, Changes, Git Data |
Build 3.6 :: operator-bundle_3.x/970: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2568: Console, Changes, Git Data |
Build 3.6 :: operator-bundle_3.x/971: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2569: Console, Changes, Git Data |
Build 3.6 :: push-latest-container-to-quay_3.x/1853: Console, Changes, Git Data |
Build 3.6 :: copyIIBsToQuay/1080: Console, Changes, Git Data |
Build 3.6 :: push-latest-container-to-quay_3.x/1853: Copied: devspaces-operator-bundle; bundle-generated updated; |
Build 3.6 :: sync-to-downstream_3.x/2569: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2446 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.6 :: operator-bundle_3.x/971: Upstream sync done; /DS_CI/sync-to-downstream_3.x/2569 triggered |
Build 3.6 :: operator-bundle_3.x/972: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2572: Console, Changes, Git Data |
Build 3.6 :: push-latest-container-to-quay_3.x/1855: Console, Changes, Git Data |
Build 3.6 :: copyIIBsToQuay/1082: Console, Changes, Git Data |
Build 3.6 :: push-latest-container-to-quay_3.x/1855: Copied: devspaces-operator-bundle; bundle-generated updated; |
Build 3.6 :: sync-to-downstream_3.x/2572: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2448 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.6 :: operator-bundle_3.x/972: Upstream sync done; /DS_CI/sync-to-downstream_3.x/2572 triggered |
Build 3.6 :: operator-bundle_3.x/974: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2578: Console, Changes, Git Data |
What does this PR do?
feat: Remove PostgreSQL component
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#21374
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.